Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1241)

Issue 7064048: code review 7064048: 6g/6c: Add flag to support position independent code ge... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by elias.naur
Modified:
11 years, 1 month ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

6g/6c: Add flag to support position independent code generation in the 6g/6c compilers. Added the -pic flag to 6c and 6g to avoid assembler instructions that cannot use RIP-relative adressing. This is needed to support the -shared mode in 6l. See also: https://codereview.appspot.com/6926049 https://codereview.appspot.com/6822078

Patch Set 1 #

Patch Set 2 : diff -r 8906cf341c9b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8906cf341c9b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b3af92ac5a0c https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -6 lines) Patch
M src/cmd/6c/sgen.c View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M src/cmd/6g/cgen.c View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
M src/cmd/6g/ggen.c View 1 2 3 2 chunks +9 lines, -1 line 0 comments Download
M src/cmd/6g/gsubr.c View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M src/cmd/cc/cc.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/cc/lex.c View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/gc/go.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/gc/lex.c View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/make.bash View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4
elias.naur
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 2 months ago (2013-01-07 19:13:53 UTC) #1
rsc
This looks fine except that it is not position-independent code, as Ian confirmed. Let's call ...
11 years, 2 months ago (2013-01-30 16:31:31 UTC) #2
elias.naur
On 2013/01/30 16:31:31, rsc wrote: > This looks fine except that it is not position-independent ...
11 years, 1 month ago (2013-01-31 18:05:18 UTC) #3
rsc
11 years, 1 month ago (2013-02-01 16:35:31 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=c9e8491bbfce ***

cmd/6c, cmd/6g: add flag to support large-model code generation

Added the -pic flag to 6c and 6g to avoid assembler instructions that
cannot use RIP-relative adressing. This is needed to support the -shared mode
in 6l.

See also:
https://codereview.appspot.com/6926049
https://codereview.appspot.com/6822078

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7064048

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b