Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(850)

Issue 6912047: environs/openstack: fix tests

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by niemeyer
Modified:
9 years, 1 month ago
Reviewers:
dimitern, mp+138767, fwereade
Visibility:
Public.

Description

environs/openstack: fix tests HEADS UP: Please do not break trunk tests. Before committing changes, make sure that tests in trunk are actually passing against whatever revision of the packages depended upon that are *currently* public, so that other people can continue to rely on trunk for their work. https://code.launchpad.net/~niemeyer/juju-core/fix-openstack-tests/+merge/138767 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/openstack: fix tests #

Patch Set 3 : environs/openstack: fix tests #

Patch Set 4 : environs/openstack: fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M environs/openstack/config_test.go View 1 2 chunks +1 line, -5 lines 0 comments Download
M environs/openstack/local_test.go View 1 2 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 7
niemeyer
Please take a look.
9 years, 1 month ago (2012-12-07 16:15:10 UTC) #1
dimitern
On 2012/12/07 16:15:10, niemeyer wrote: > Please take a look. LGTM
9 years, 1 month ago (2012-12-07 16:17:39 UTC) #2
niemeyer
Please take a look.
9 years, 1 month ago (2012-12-07 16:18:01 UTC) #3
fwereade
LGTM
9 years, 1 month ago (2012-12-07 16:18:53 UTC) #4
niemeyer
Please take a look.
9 years, 1 month ago (2012-12-07 16:20:23 UTC) #5
fwereade
Still LGTM
9 years, 1 month ago (2012-12-07 16:28:47 UTC) #6
niemeyer
9 years, 1 month ago (2012-12-07 16:37:50 UTC) #7
*** Submitted:

environs/openstack: fix tests

HEADS UP: Please do not break trunk tests. Before committing changes,
make sure that tests in trunk are actually passing against whatever
revision of the packages depended upon that are *currently* public,
so that other people can continue to rely on trunk for their work.

R=dimitern, fwereade
CC=
https://codereview.appspot.com/6912047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b