Issue 6912047: environs/openstack: fix tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6912047: environs/openstack: fix tests

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by niemeyer

Modified:
11 years, 4 months ago

Reviewers:
dimitern, mp+138767, fwereade

Visibility:
Public.

Description

environs/openstack: fix tests HEADS UP: Please do not break trunk tests. Before committing changes, make sure that tests in trunk are actually passing against whatever revision of the packages depended upon that are *currently* public, so that other people can continue to rely on trunk for their work. https://code.launchpad.net/~niemeyer/juju-core/fix-openstack-tests/+merge/138767 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/openstack: fix tests #

Patch Set 3 : environs/openstack: fix tests #

Patch Set 4 : environs/openstack: fix tests #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -5 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/openstack/config_test.go	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	environs/openstack/local_test.go	View	1 2	1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

dimitern

On 2012/12/07 16:15:10, niemeyer wrote: > Please take a look. LGTM

11 years, 4 months ago (2012-12-07 16:17:39 UTC) #2

niemeyer

11 years, 4 months ago (2012-12-07 16:37:50 UTC) #7

*** Submitted:

environs/openstack: fix tests

HEADS UP: Please do not break trunk tests. Before committing changes,
make sure that tests in trunk are actually passing against whatever
revision of the packages depended upon that are *currently* public,
so that other people can continue to rely on trunk for their work.

R=dimitern, fwereade
CC=
https://codereview.appspot.com/6912047

Expand All Messages | Collapse All Messages