Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(285)

Issue 6905059: Exclude config.js from minification

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by matthew.scott
Modified:
11 years, 5 months ago
Reviewers:
mp+139033
Visibility:
Public.

Description

Exclude config.js from minification config(-debug).js should not be included in minification because it is already included in index.html, and needs to be modified in the charm start hook after the build process. https://code.launchpad.net/~makyo/juju-gui/config-separate/+merge/139033 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Exclude config.js from minification #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M bin/merge-files View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 4
matthew.scott
Please take a look.
11 years, 5 months ago (2012-12-10 16:46:15 UTC) #1
gary.poster
Land with changes Thank you! Approved with trivial comment request. Gary https://codereview.appspot.com/6905059/diff/1/bin/merge-files File bin/merge-files (right): ...
11 years, 5 months ago (2012-12-10 17:18:20 UTC) #2
teknico
Thanks for noticing this, Matthew.
11 years, 5 months ago (2012-12-10 17:29:24 UTC) #3
matthew.scott
11 years, 5 months ago (2012-12-10 17:41:01 UTC) #4
*** Submitted:

Exclude config.js from minification

config(-debug).js should not be included in minification because it is already
included in index.html, and needs to be modified in the charm start hook after
the build process.

R=teknico
CC=
https://codereview.appspot.com/6905059
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b