Exclude config.js from minification

bin/merge-files

 #!/usr/bin/env node
 
 /*
  * We aggregate and minimize the JavaScript sources in order to improve the
  * load speed of the application.
  *
  * We don't want to use the YUI combo loader feature because we want to be able
  * to run from only static files and we want to be able to run behind a
  * firewall without access to the internet.
  *
@@ skipping 18 matching lines @@
 
 require('yui').YUI().use(['yui'], function(Y) {
   var merge = require('../lib/merge-files.js');
   var syspath = require('path');
 
   // First we find all of the paths to our custom Javascript in the app
   // directory.  We need to tell the function to ignore the "assets" directory
   // and the debug version of the modules file. I need to use
   // "syspath.join(process.cwd(), ...)" or else I have... "Error: Cannot find
   // module 'app/config.js'" from node's internal module.js file.
+  // config(-debug).js should also be passed in the ignore list: these files
+  // are included in index.html separately as part of charm configuration,
+  // and should not also be included in the minification.
   var paths = merge.readdir(syspath.join(process.cwd(), 'app'),
     [syspath.join(process.cwd(), 'app/assets'),
      syspath.join(process.cwd(), 'app/modules-debug.js'),
      syspath.join(process.cwd(), 'app/config.js'),
      syspath.join(process.cwd(), 'app/config-debug.js')]);

[gary.poster, 2012/12/10 17:18:20]

Please add a comment explaining why this is important, for our future selves.

 
   // templates.js is a generated file. It is not part of the app directory.
   paths.push(syspath.join(process.cwd(), 'build/juju-ui/templates.js'));
 
   merge.combineJs(paths, 'build/juju-ui/assets/app.js');
 
   // Get the paths to the YUI modules that we use.
   var reqs = merge.loadRequires(paths);
 
   // For some reason the loader does not get these requirements.
@@ skipping 16 matching lines @@
     'app/assets/javascripts/svg-layouts.js']);
 
   merge.combineJs(filesToLoad.js, 'build/juju-ui/assets/all-yui.js');
 
   var cssFiles = filesToLoad.css;
   cssFiles.push('app/assets/stylesheets/bootstrap-2.0.4.css');
   cssFiles.push('app/assets/stylesheets/bootstrap-responsive-2.0.4.css');
   merge.combineCSS(cssFiles,
     'build/juju-ui/assets/combined-css/all-static.css');
 });