code review 69040044: all: final merge of NaCl tree

all: final merge of NaCl tree

This CL replays the following one CL from the rsc-go13nacl repo.
This is the last replay CL: after this CL the main repo will have
everything the rsc-go13nacl repo did. Changes made to the main
repo after the rsc-go13nacl repo branched off probably mean that
NaCl doesn't actually work after this CL, but all the code is now moved
over and just needs to be redebugged.

---
cmd/6l, cmd/8l, cmd/ld: support for Native Client

See golang.org/s/go13nacl for design overview.

This CL is publicly visible but not CC'ed to golang-dev,
to avoid distracting from the preparation of the Go 1.2
release.

This CL and the others will be checked into my rsc-go13nacl
clone repo for now, and I will send CLs against the main
repo early in the Go 1.3 development.

R≡khr
https://codereview.appspot.com/15750044
---

[rsc, 2014-02-26 21:10:42]

Hello dfc (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2014-02-26 22:33:08]

LGTM

[dave_cheney.net, 2014-02-26 23:42:39]

Passes on darwin/amd64, amd testing 386 and arm now.

I have not attempted to cross compile to amd64p32 yet.


On Thu, Feb 27, 2014 at 9:33 AM, <bradfitz@golang.org> wrote:

> LGTM
>
>
> https://codereview.appspot.com/69040044/
>

[dave_cheney.net, 2014-02-27 00:18:59]

LGTM. linux/arm and linux/386 pass. I'll try some cross compilation
experiments later tonight, I'm hopeful that the binaries produced won't be
too far from passing validation.


On Thu, Feb 27, 2014 at 10:42 AM, Dave Cheney <dave@cheney.net> wrote:

> Passes on darwin/amd64, amd testing 386 and arm now.
>
> I have not attempted to cross compile to amd64p32 yet.
>
>
> On Thu, Feb 27, 2014 at 9:33 AM, <bradfitz@golang.org> wrote:
>
>> LGTM
>>
>>
>> https://codereview.appspot.com/69040044/
>>
>
>

[iant, 2014-02-27 00:52:10]

LGTM

https://codereview.appspot.com/69040044/diff/40001/src/cmd/6l/obj.c
File src/cmd/6l/obj.c (right):

https://codereview.appspot.com/69040044/diff/40001/src/cmd/6l/obj.c#newcode127
src/cmd/6l/obj.c:127: HEADR = 0x10000;
Seems like it wouldn't be crazy to make Hnacl a separate case.  You are
overwriting every value except INITDAT.

https://codereview.appspot.com/69040044/diff/40001/src/cmd/8l/obj.c
File src/cmd/8l/obj.c (right):

https://codereview.appspot.com/69040044/diff/40001/src/cmd/8l/obj.c#newcode105
src/cmd/8l/obj.c:105: if(HEADTYPE == Hnacl) {
Separate case?

https://codereview.appspot.com/69040044/diff/40001/src/liblink/sym.c
File src/liblink/sym.c (right):

https://codereview.appspot.com/69040044/diff/40001/src/liblink/sym.c#newcode52
src/liblink/sym.c:52: "nacl",	Hnacl,
Indentation does not match.

[rsc, 2014-02-28 01:37:04]

*** Submitted as https://code.google.com/p/go/source/detail?r=ffcbc9233426 ***

all: final merge of NaCl tree

This CL replays the following one CL from the rsc-go13nacl repo.
This is the last replay CL: after this CL the main repo will have
everything the rsc-go13nacl repo did. Changes made to the main
repo after the rsc-go13nacl repo branched off probably mean that
NaCl doesn't actually work after this CL, but all the code is now moved
over and just needs to be redebugged.

---
cmd/6l, cmd/8l, cmd/ld: support for Native Client

See golang.org/s/go13nacl for design overview.

This CL is publicly visible but not CC'ed to golang-dev,
to avoid distracting from the preparation of the Go 1.2
release.

This CL and the others will be checked into my rsc-go13nacl
clone repo for now, and I will send CLs against the main
repo early in the Go 1.3 development.

R≡khr
https://codereview.appspot.com/15750044
---

LGTM=bradfitz, dave, iant
R=dave, bradfitz, iant
CC=golang-codereviews
https://codereview.appspot.com/69040044

[gobot, 2014-02-28 01:50:50]

This CL appears to have broken the windows-386-ec2 builder.

[dvyukov, 2014-02-28 09:07:12]

we seem to have nacl maintainer, but what about the builder?


On Fri, Feb 28, 2014 at 5:37 AM,  <rsc@golang.org> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=ffcbc9233426 ***
>
>
> all: final merge of NaCl tree
>
> This CL replays the following one CL from the rsc-go13nacl repo.
> This is the last replay CL: after this CL the main repo will have
> everything the rsc-go13nacl repo did. Changes made to the main
> repo after the rsc-go13nacl repo branched off probably mean that
> NaCl doesn't actually work after this CL, but all the code is now moved
> over and just needs to be redebugged.
>
> ---
> cmd/6l, cmd/8l, cmd/ld: support for Native Client
>
> See golang.org/s/go13nacl for design overview.
>
> This CL is publicly visible but not CC'ed to golang-dev,
> to avoid distracting from the preparation of the Go 1.2
> release.
>
> This CL and the others will be checked into my rsc-go13nacl
> clone repo for now, and I will send CLs against the main
> repo early in the Go 1.3 development.
>
> R≡khr
> https://codereview.appspot.com/15750044
> ---
>
> LGTM=bradfitz, dave, iant
> R=dave, bradfitz, iant
> CC=golang-codereviews
> https://codereview.appspot.com/69040044
>
>
>
> https://codereview.appspot.com/69040044/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

[dave_cheney.net, 2014-02-28 09:50:08]

I had hoped that the owners of the current linux/* builders (which I think
is Brad and Andrew) would be able to add a key for a nacl-amd64p32 builder.

In the interim I could run one if necessary.

Cheers

Dave


On Fri, Feb 28, 2014 at 8:06 PM, Dmitry Vyukov <dvyukov@google.com> wrote:

> we seem to have nacl maintainer, but what about the builder?
>
>
> On Fri, Feb 28, 2014 at 5:37 AM,  <rsc@golang.org> wrote:
> > *** Submitted as
> > https://code.google.com/p/go/source/detail?r=ffcbc9233426 ***
> >
> >
> > all: final merge of NaCl tree
> >
> > This CL replays the following one CL from the rsc-go13nacl repo.
> > This is the last replay CL: after this CL the main repo will have
> > everything the rsc-go13nacl repo did. Changes made to the main
> > repo after the rsc-go13nacl repo branched off probably mean that
> > NaCl doesn't actually work after this CL, but all the code is now moved
> > over and just needs to be redebugged.
> >
> > ---
> > cmd/6l, cmd/8l, cmd/ld: support for Native Client
> >
> > See golang.org/s/go13nacl for design overview.
> >
> > This CL is publicly visible but not CC'ed to golang-dev,
> > to avoid distracting from the preparation of the Go 1.2
> > release.
> >
> > This CL and the others will be checked into my rsc-go13nacl
> > clone repo for now, and I will send CLs against the main
> > repo early in the Go 1.3 development.
> >
> > R≡khr
> > https://codereview.appspot.com/15750044
> > ---
> >
> > LGTM=bradfitz, dave, iant
> > R=dave, bradfitz, iant
> > CC=golang-codereviews
> > https://codereview.appspot.com/69040044
> >
> >
> >
> > https://codereview.appspot.com/69040044/
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "golang-codereviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to golang-codereviews+unsubscribe@googlegroups.com.
> > For more options, visit https://groups.google.com/groups/opt_out.
>

[rsc, 2014-02-28 10:43:43]

we're going to set up a nacl builder on one of the linux builders.
it's not working yet - just merged - so we aren't exactly ready for the
builder just now.
but brad is on it.

russ