Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(266)

Issue 15750044: code review 15750044: cmd/6l, cmd/8l, cmd/ld: support for Native Client (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by rsc
Modified:
12 years, 1 month ago
Reviewers:
khr
CC:
khr
Visibility:
Public.

Description

cmd/6l, cmd/8l, cmd/ld: support for Native Client See golang.org/s/go13nacl for design overview. This CL is publicly visible but not CC'ed to golang-dev, to avoid distracting from the preparation of the Go 1.2 release. This CL and the others will be checked into my rsc-go13nacl clone repo for now, and I will send CLs against the main repo early in the Go 1.3 development.

Patch Set 1 #

Patch Set 2 : diff -r 6752a7aad603 https://code.google.com/r/rsc-go13nacl #

Patch Set 3 : diff -r 6752a7aad603 https://code.google.com/r/rsc-go13nacl #

Patch Set 4 : diff -r 6752a7aad603 https://code.google.com/r/rsc-go13nacl #

Patch Set 5 : diff -r 6752a7aad603 https://code.google.com/r/rsc-go13nacl #

Patch Set 6 : diff -r eca0ca43a863 https://code.google.com/r/rsc-go13nacl #

Patch Set 7 : diff -r de159d1f10be https://code.google.com/r/rsc-go13nacl #

Total comments: 2

Patch Set 8 : diff -r 500771b477cf https://code.google.com/r/rsc-go13nacl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+529 lines, -109 lines) Patch
M src/cmd/5l/l.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/5l/obj.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/6l/asm.c View 1 3 chunks +3 lines, -0 lines 0 comments Download
M src/cmd/6l/l.h View 1 2 4 chunks +6 lines, -3 lines 0 comments Download
M src/cmd/6l/obj.c View 1 2 11 chunks +53 lines, -3 lines 0 comments Download
M src/cmd/6l/pass.c View 1 2 3 4 5 15 chunks +56 lines, -25 lines 0 comments Download
M src/cmd/6l/span.c View 1 2 14 chunks +212 lines, -15 lines 0 comments Download
M src/cmd/8l/asm.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/8l/l.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/cmd/8l/obj.c View 1 5 chunks +12 lines, -0 lines 0 comments Download
M src/cmd/8l/pass.c View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/cmd/8l/span.c View 1 6 chunks +106 lines, -2 lines 0 comments Download
M src/cmd/ld/data.c View 1 3 chunks +4 lines, -3 lines 0 comments Download
M src/cmd/ld/decodesym.c View 1 7 chunks +28 lines, -19 lines 0 comments Download
M src/cmd/ld/elf.c View 1 2 13 chunks +30 lines, -27 lines 0 comments Download
M src/cmd/ld/lib.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/cmd/ld/lib.c View 1 2 4 chunks +8 lines, -6 lines 0 comments Download
M src/pkg/runtime/type.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/typekind.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4
khr
LGTM. https://codereview.appspot.com/15750044/diff/150001/src/cmd/6l/obj.c File src/cmd/6l/obj.c (right): https://codereview.appspot.com/15750044/diff/150001/src/cmd/6l/obj.c#newcode143 src/cmd/6l/obj.c:143: IntSize = 4; Shouldn't IntSize be 8?
12 years, 1 month ago (2013-11-07 22:43:30 UTC) #1
rsc
https://codereview.appspot.com/15750044/diff/150001/src/cmd/6l/obj.c File src/cmd/6l/obj.c (right): https://codereview.appspot.com/15750044/diff/150001/src/cmd/6l/obj.c#newcode143 src/cmd/6l/obj.c:143: IntSize = 4; On 2013/11/07 22:43:30, khr wrote: > ...
12 years, 1 month ago (2013-11-08 00:38:13 UTC) #2
rsc
Hello khr@golang.org, I'd like you to review this change to https://code.google.com/r/rsc-go13nacl
12 years, 1 month ago (2013-11-11 14:50:14 UTC) #3
rsc
12 years, 1 month ago (2013-11-11 14:50:21 UTC) #4
*** Submitted as 228a67edf974 ***

cmd/6l, cmd/8l, cmd/ld: support for Native Client

See golang.org/s/go13nacl for design overview.

This CL is publicly visible but not CC'ed to golang-dev,
to avoid distracting from the preparation of the Go 1.2
release.

This CL and the others will be checked into my rsc-go13nacl
clone repo for now, and I will send CLs against the main
repo early in the Go 1.3 development.

R=khr
https://codereview.appspot.com/15750044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b