System SSH key upgrader

System SSH key upgrader

Add upgrader to generate system SSH key.

https://code.launchpad.net/~wallyworld/juju-core/system-sshkey-upgrader/+merge/208277

Requires: https://code.launchpad.net/~wallyworld/juju-core/machine-agent-run-upgrades/+merge/208060

(do not edit description out of merge proposal)

[wallyworld, 2014-02-26 05:33:33]

Please take a look.

[wallyworld, 2014-02-26 05:46:57]

Please take a look.

[thumper, 2014-02-27 00:36:27]

LGTM with a few trivial tests added.

https://codereview.appspot.com/68990043/diff/20001/environs/config/authkeys.go
File environs/config/authkeys.go (right):

https://codereview.appspot.com/68990043/diff/20001/environs/config/authkeys.g...
environs/config/authkeys.go:92: if a == "" {
do we have an authkeys_test.go? Would be good to just see a few tests for this.

https://codereview.appspot.com/68990043/diff/20001/upgrades/systemsshkey.go
File upgrades/systemsshkey.go (right):

https://codereview.appspot.com/68990043/diff/20001/upgrades/systemsshkey.go#n...
upgrades/systemsshkey.go:48: return ioutil.WriteFile(identityFile,
[]byte(privateKey), 0600)
So wish we had real transactions so we could persist the file in our db, and if
writing the file failed, it would be rolled back.  But c'est la vie.

[wallyworld, 2014-02-27 03:19:41]

Please take a look.

[wallyworld, 2014-02-27 05:36:54]

Please take a look.

https://codereview.appspot.com/68990043/diff/20001/environs/config/authkeys.go
File environs/config/authkeys.go (right):

https://codereview.appspot.com/68990043/diff/20001/environs/config/authkeys.g...
environs/config/authkeys.go:92: if a == "" {
On 2014/02/27 00:36:27, thumper wrote:
> do we have an authkeys_test.go? Would be good to just see a few tests for
this.

Done.