Issue 6875044: code review 6875044: net: simplify ListenTCP

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6875044: code review 6875044: net: simplify ListenTCP (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by mikio

Modified:
11 years, 4 months ago

Reviewers:

CC:
golang-dev, dave_cheney.net

Visibility:
Public.

Description

net: simplify ListenTCP

Patch Set 1 #

Patch Set 2 : diff -r d05272f402ec https://code.google.com/p/go #

Patch Set 3 : diff -r d05272f402ec https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r d05272f402ec https://code.google.com/p/go #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	src/pkg/net/tcpsock_posix.go	View	1	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 4 months ago (2012-12-03 04:27:55 UTC) #1

dave_cheney.net

LGTM with the minor change in the case that TCPListener grows another private field in ...

11 years, 4 months ago (2012-12-03 05:07:35 UTC) #2

mikio

11 years, 4 months ago (2012-12-03 11:01:04 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=c89043efd31c ***

net: simplify ListenTCP

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/6875044

Expand All Messages | Collapse All Messages