Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(297)

Issue 6875044: code review 6875044: net: simplify ListenTCP (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by mikio
Modified:
9 years, 10 months ago
Reviewers:
CC:
golang-dev, dfc
Visibility:
Public.

Description

net: simplify ListenTCP

Patch Set 1 #

Patch Set 2 : diff -r d05272f402ec https://code.google.com/p/go #

Patch Set 3 : diff -r d05272f402ec https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r d05272f402ec https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/pkg/net/tcpsock_posix.go View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 10 months ago (2012-12-03 04:27:55 UTC) #1
dfc
LGTM with the minor change in the case that TCPListener grows another private field in ...
9 years, 10 months ago (2012-12-03 05:07:35 UTC) #2
mikio
9 years, 10 months ago (2012-12-03 11:01:04 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=c89043efd31c ***

net: simplify ListenTCP

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/6875044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b