Issue 6871043: code review 6871043: cmd/gc: fix inlining internal error with T.Method calls.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6871043: code review 6871043: cmd/gc: fix inlining internal error with T.Method calls. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by remyoudompheng

Modified:
11 years, 4 months ago

Reviewers:

CC:
golang-dev, rsc, lvd2

Visibility:
Public.

Description

cmd/gc: fix inlining internal error with T.Method calls. The compiler was confused when inlining a T.Method(f()) call where f returns multiple values: support for this was marked as TODO. Variadic calls are not supported but are not inlined either. Add a test preventively for that case. Fixes issue 4167.

Patch Set 1 #

Patch Set 2 : diff -r 6ec24fe2e501 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6ec24fe2e501 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c89043efd31c https://go.googlecode.com/hg/ #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -32 lines)			Patch
	M	src/cmd/gc/inl.c	View	1	2 chunks	+35 lines, -32 lines	0 comments	Download
	A	test/fixedbugs/issue4167.go	View	1	1 chunk	+50 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com, rsc@golang.org, lvd@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 4 months ago (2012-12-01 22:15:46 UTC) #1

remyoudompheng

11 years, 4 months ago (2012-12-03 12:39:48 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=230e82a3bbf4 ***

cmd/gc: fix inlining internal error with T.Method calls.

The compiler was confused when inlining a T.Method(f()) call
where f returns multiple values: support for this was marked
as TODO.

Variadic calls are not supported but are not inlined either.
Add a test preventively for that case.

Fixes issue 4167.

R=golang-dev, rsc, lvd
CC=golang-dev
https://codereview.appspot.com/6871043

Expand All Messages | Collapse All Messages