Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(250)

Issue 6871043: code review 6871043: cmd/gc: fix inlining internal error with T.Method calls. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by remyoudompheng
Modified:
10 years ago
Reviewers:
CC:
golang-dev, rsc, lvd2
Visibility:
Public.

Description

cmd/gc: fix inlining internal error with T.Method calls. The compiler was confused when inlining a T.Method(f()) call where f returns multiple values: support for this was marked as TODO. Variadic calls are not supported but are not inlined either. Add a test preventively for that case. Fixes issue 4167.

Patch Set 1 #

Patch Set 2 : diff -r 6ec24fe2e501 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6ec24fe2e501 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c89043efd31c https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -32 lines) Patch
M src/cmd/gc/inl.c View 1 2 chunks +35 lines, -32 lines 0 comments Download
A test/fixedbugs/issue4167.go View 1 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 3
remyoudompheng
Hello golang-dev@googlegroups.com, rsc@golang.org, lvd@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years ago (2012-12-01 22:15:46 UTC) #1
lvd2
LGTM
10 years ago (2012-12-03 11:06:16 UTC) #2
remyoudompheng
10 years ago (2012-12-03 12:39:48 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=230e82a3bbf4 ***

cmd/gc: fix inlining internal error with T.Method calls.

The compiler was confused when inlining a T.Method(f()) call
where f returns multiple values: support for this was marked
as TODO.

Variadic calls are not supported but are not inlined either.
Add a test preventively for that case.

Fixes issue 4167.

R=golang-dev, rsc, lvd
CC=golang-dev
https://codereview.appspot.com/6871043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b