Charm panel border improvements

Charm panel border improvements

From Matt C.: Shadow should be darker on darker areas in the panel (such as the charm name and search result headings), and the border should extend all the way down to the bottom of the view (was 1px short).

Per UX review, colors updated and inset box-shadow on bottom.

https://code.launchpad.net/~makyo/juju-gui/charm-panel-border2/+merge/134354

(do not edit description out of merge proposal)

[matthew.scott, 2012-11-14 18:26:12]

Please take a look.

[bac, 2012-11-15 11:54:39]

The branch and the visual results look good.  Thanks for the fixes and to Matt
C. for catching our 1 pixel mistakes.

https://codereview.appspot.com/6855049/diff/1/lib/views/stylesheet.less
File lib/views/stylesheet.less (right):

https://codereview.appspot.com/6855049/diff/1/lib/views/stylesheet.less#newco...
lib/views/stylesheet.less:1042: border-left: 1px solid #CBCBCB - #333;
Nice!  I see this is a novel use of CBCBCB but it might be nice to define it as
a LESS variable.  Having them all at the top would help us to see all of the
colors we're using.  Your call.  Perhaps, if we decide to do that, we could have
one big color naming branch.

[frankban, 2012-11-16 15:16:40]

Nice branch Matthew.
Nothing to add to what Brad wrote.
The tests pass and the panel looks good.

[matthew.scott, 2012-11-16 16:49:09]

Thanks for the reviews!

https://codereview.appspot.com/6855049/diff/1/lib/views/stylesheet.less
File lib/views/stylesheet.less (right):

https://codereview.appspot.com/6855049/diff/1/lib/views/stylesheet.less#newco...
lib/views/stylesheet.less:1042: border-left: 1px solid #CBCBCB - #333;
On 2012/11/15 11:54:39, bac wrote:
> Nice!  I see this is a novel use of CBCBCB but it might be nice to define it
as
> a LESS variable.  Having them all at the top would help us to see all of the
> colors we're using.  Your call.  Perhaps, if we decide to do that, we could
have
> one big color naming branch.

I agree on naming colors, and I've gone ahead and done this one and one other I
modified in this branch, but I will save the rest for a color naming branch,
maybe as a slack task.

[matthew.scott, 2012-11-16 17:10:00]

*** Submitted:

Charm panel border improvements

From Matt C.: Shadow should be darker on darker areas in the panel (such as the
charm name and search result headings), and the border should extend all the way
down to the bottom of the view (was 1px short).

R=bac, francesco.banconi
CC=
https://codereview.appspot.com/6855049

[matthew.scott, 2012-11-27 16:54:05]

*** Submitted:

Charm panel border improvements

From Matt C.: Shadow should be darker on darker areas in the panel (such as the
charm name and search result headings), and the border should extend all the way
down to the bottom of the view (was 1px short).

Per UX review, colors updated and inset box-shadow on bottom.

R=
CC=
https://codereview.appspot.com/6855049