Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(195)

Issue 6855049: Charm panel border improvements

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by matthew.scott
Modified:
8 years ago
Reviewers:
mp+134354
Visibility:
Public.

Description

Charm panel border improvements From Matt C.: Shadow should be darker on darker areas in the panel (such as the charm name and search result headings), and the border should extend all the way down to the bottom of the view (was 1px short). Per UX review, colors updated and inset box-shadow on bottom. https://code.launchpad.net/~makyo/juju-gui/charm-panel-border2/+merge/134354 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Charm panel border improvements #

Patch Set 3 : Charm panel border improvements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/charm-panel.js View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M lib/views/stylesheet.less View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6
matthew.scott
Please take a look.
8 years ago (2012-11-14 18:26:12 UTC) #1
bac
The branch and the visual results look good. Thanks for the fixes and to Matt ...
8 years ago (2012-11-15 11:54:39 UTC) #2
frankban
Nice branch Matthew. Nothing to add to what Brad wrote. The tests pass and the ...
8 years ago (2012-11-16 15:16:40 UTC) #3
matthew.scott
Thanks for the reviews! https://codereview.appspot.com/6855049/diff/1/lib/views/stylesheet.less File lib/views/stylesheet.less (right): https://codereview.appspot.com/6855049/diff/1/lib/views/stylesheet.less#newcode1042 lib/views/stylesheet.less:1042: border-left: 1px solid #CBCBCB - ...
8 years ago (2012-11-16 16:49:09 UTC) #4
matthew.scott
*** Submitted: Charm panel border improvements From Matt C.: Shadow should be darker on darker ...
8 years ago (2012-11-16 17:10:00 UTC) #5
matthew.scott
8 years ago (2012-11-27 16:54:05 UTC) #6
*** Submitted:

Charm panel border improvements

From Matt C.: Shadow should be darker on darker areas in the panel (such as the
charm name and search result headings), and the border should extend all the way
down to the bottom of the view (was 1px short).

Per UX review, colors updated and inset box-shadow on bottom.

R=
CC=
https://codereview.appspot.com/6855049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b