Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4102)

Issue 6846119: code review 6846119: godoc: remove main package if main and once more packag...

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by mattn
Modified:
10 years, 9 months ago
Reviewers:
minux1, golang-dev, khr, rsc
CC:
golang-dev
Visibility:
Public.

Description

godoc: remove main package if main and once more package exists. Below should work. $ godoc net/http

Patch Set 1 #

Patch Set 2 : diff -r 1289e67dec66 http://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1289e67dec66 http://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M src/cmd/godoc/godoc.go View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5
mattn
Hello golang-dev@googlecode.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to http://go.googlecode.com/hg/
11 years, 5 months ago (2012-11-28 02:45:14 UTC) #1
rsc
NOT LGTM 'godoc net/http' works fine for me already. We used to have logic like ...
11 years, 5 months ago (2012-11-29 03:20:53 UTC) #2
minux1
On Thu, Nov 29, 2012 at 11:20 AM, Russ Cox <rsc@golang.org> wrote: > 'godoc net/http' ...
11 years, 5 months ago (2012-11-29 04:53:51 UTC) #3
minux1
Found real problem, sent http://codereview.appspot.com/6852100
11 years, 5 months ago (2012-11-29 06:04:58 UTC) #4
khr
10 years, 9 months ago (2013-07-22 19:45:13 UTC) #5
R=close
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b