code review 6852100: cmd/godoc: fix `godoc net/http` on windows

cmd/godoc: fix `godoc net/http` on windows
`godoc net/http` used to complain "/target contains more than one package: http, main"

[minux1, 2012-11-29 06:05:43]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2012-11-29 06:28:39]

LGTM

filesystem.go could use some more comments (one day) about which things take
paths vs filepaths.  they're all named "path", too.

[minux1, 2012-11-29 09:00:21]

On Thu, Nov 29, 2012 at 2:28 PM, <bradfitz@golang.org> wrote:

> filesystem.go could use some more comments (one day) about which things
> take paths vs filepaths.  they're all named "path", too
>
Excerpt from filesystem.go:
// fs is the file system that godoc reads from and serves.
// It is a virtual file system that operates on slash-separated paths,

I think this comment makes it clear that all methods of fs take
slash-separated paths.

[rsc, 2012-11-29 17:25:24]

I see that this is probably correct, but since Windows accepts both / and \ as
path separators I don't understand how this would change the behavior that mattn
was seeing. How did this cause the godoc bug?

[rsc, 2012-11-29 19:37:01]

LGTM

Okay, makes sense to me. I was reading the relationships backwards.

[minux1, 2012-11-29 19:44:53]

On Fri, Nov 30, 2012 at 1:25 AM, <rsc@golang.org> wrote:

> I see that this is probably correct, but since Windows accepts both /
> and \ as path separators I don't understand how this would change the
> behavior that mattn was seeing. How did this cause the godoc bug?
>
because path/filepath will always use \ as path separator, and godoc.go
always
uses path/filepath to handle file paths, so paths passed to fs.ReadDir are
always
using \ as path separator.

I will wait for mattn to verify if this fixes the problem.

[minux1, 2012-11-30 16:43:09]

*** Submitted as https://code.google.com/p/go/source/detail?r=6aab0212379c ***

cmd/godoc: fix `godoc net/http` on windows
`godoc net/http` used to complain "/target contains more than one package: http,
main"

R=golang-dev, bradfitz, rsc
CC=golang-dev
https://codereview.appspot.com/6852100