Issue 6845084: Remove "requires" properties.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6845084: Remove "requires" properties.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by benji

Modified:
11 years, 5 months ago

Reviewers:
mp+135952

Visibility:
Public.

Description

Remove "requires" properties. The minification process does not read the "requires" parameters defined in "all-app-debug.js". This parameter should be defined in each custom yui object that uses some kind of internal or external requirement. The sole use of "all-app-debug.js" is to define the fullpath of the file that defines a given module. This patch removes all the existing "requires" properties from "all-app-debug.js" and add then where they are needed. https://code.launchpad.net/~benji/juju-gui/bug-1081205/+merge/135952 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Remove "requires" properties. #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+810 lines, -847 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/app.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	app/models/charm.js	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	app/models/models.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	app/modules-debug.js	View	4 chunks	+8 lines, -12 lines	0 comments	Download
M	app/store/charm.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/test_app.js	View	1 chunk	+176 lines, -191 lines	0 comments	Download
M	test/test_app_hotkeys.js	View	2 chunks	+52 lines, -52 lines	0 comments	Download
M	test/test_model.js	View	4 chunks	+18 lines, -25 lines	0 comments	Download
M	test/test_notifications.js	View	1 chunk	+454 lines, -469 lines	0 comments	Download
M	test/test_notifier_widget.js	View	1 chunk	+95 lines, -97 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

benji

11 years, 5 months ago (2012-11-23 17:27:38 UTC) #2

*** Submitted:

Remove "requires" properties.

The minification process does not read the "requires" parameters defined in
"all-app-debug.js". This parameter should be defined in each custom yui object
that uses some kind of internal or external requirement. The sole use of
"all-app-debug.js" is to define the fullpath of the file that defines a given
module.

This patch removes all the existing "requires" properties from
"all-app-debug.js" and add then where they are needed.

R=
CC=
https://codereview.appspot.com/6845084

Expand All Messages | Collapse All Messages