Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(262)

Issue 6845084: Remove "requires" properties.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by benji
Modified:
8 years ago
Reviewers:
mp+135952
Visibility:
Public.

Description

Remove "requires" properties. The minification process does not read the "requires" parameters defined in "all-app-debug.js". This parameter should be defined in each custom yui object that uses some kind of internal or external requirement. The sole use of "all-app-debug.js" is to define the fullpath of the file that defines a given module. This patch removes all the existing "requires" properties from "all-app-debug.js" and add then where they are needed. https://code.launchpad.net/~benji/juju-gui/bug-1081205/+merge/135952 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Remove "requires" properties. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+810 lines, -847 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 chunk +1 line, -0 lines 0 comments Download
M app/models/charm.js View 1 chunk +2 lines, -1 line 0 comments Download
M app/models/models.js View 1 chunk +1 line, -0 lines 0 comments Download
M app/modules-debug.js View 4 chunks +8 lines, -12 lines 0 comments Download
M app/store/charm.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/test_app.js View 1 chunk +176 lines, -191 lines 0 comments Download
M test/test_app_hotkeys.js View 2 chunks +52 lines, -52 lines 0 comments Download
M test/test_model.js View 4 chunks +18 lines, -25 lines 0 comments Download
M test/test_notifications.js View 1 chunk +454 lines, -469 lines 0 comments Download
M test/test_notifier_widget.js View 1 chunk +95 lines, -97 lines 0 comments Download

Messages

Total messages: 2
benji
Please take a look.
8 years ago (2012-11-23 17:24:53 UTC) #1
benji
8 years ago (2012-11-23 17:27:38 UTC) #2
*** Submitted:

Remove "requires" properties.

The minification process does not read the "requires" parameters defined in
"all-app-debug.js". This parameter should be defined in each custom yui object
that uses some kind of internal or external requirement. The sole use of
"all-app-debug.js" is to define the fullpath of the file that defines a given
module.

This patch removes all the existing "requires" properties from
"all-app-debug.js" and add then where they are needed.

R=
CC=
https://codereview.appspot.com/6845084
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b