Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 6843068: code review 6843068: dashboard/builder: pass $CC to builder if set (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by dfc
Modified:
2 years, 4 months ago
Reviewers:
CC:
adg, minux1, rsc, golang-dev
Visibility:
Public.

Description

dashboard/builder: pass $CC to builder if set

Patch Set 1 #

Patch Set 2 : diff -r 9544314de8e8 https://code.google.com/p/go #

Patch Set 3 : diff -r 9544314de8e8 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 852ee39cc8c4 https://code.google.com/p/go #

Patch Set 5 : diff -r be66ed00e1a0 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M misc/dashboard/builder/main.go View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7
dfc
Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
2 years, 4 months ago (2012-11-16 04:42:36 UTC) #1
minux1
LGTM.
2 years, 4 months ago (2012-11-18 22:09:56 UTC) #2
minux1
https://codereview.appspot.com/6843068/diff/4001/misc/dashboard/builder/main.go File misc/dashboard/builder/main.go (right): https://codereview.appspot.com/6843068/diff/4001/misc/dashboard/builder/main.go#newcode40 misc/dashboard/builder/main.go:40: "CC", this array is sorted previously, i think you'd ...
2 years, 4 months ago (2012-11-18 22:13:15 UTC) #3
dfc
PTAL. https://codereview.appspot.com/6843068/diff/4001/misc/dashboard/builder/main.go File misc/dashboard/builder/main.go (right): https://codereview.appspot.com/6843068/diff/4001/misc/dashboard/builder/main.go#newcode40 misc/dashboard/builder/main.go:40: "CC", On 2012/11/18 22:13:16, minux wrote: > this ...
2 years, 4 months ago (2012-11-19 08:32:12 UTC) #4
minux1
LGTM.
2 years, 4 months ago (2012-11-19 10:40:10 UTC) #5
rsc
LGTM
2 years, 4 months ago (2012-11-21 18:06:02 UTC) #6
dfc
2 years, 4 months ago (2012-11-21 21:41:38 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=6cee245eb194 ***

dashboard/builder: pass $CC to builder if set

R=adg, minux.ma, rsc
CC=golang-dev
http://codereview.appspot.com/6843068
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e6eadc5