Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(18)

Side by Side Diff: misc/dashboard/builder/main.go

Issue 6843068: code review 6843068: dashboard/builder: pass $CC to builder if set (Closed)
Patch Set: diff -r 9544314de8e8 https://code.google.com/p/go Created 12 years, 4 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 The Go Authors. All rights reserved. 1 // Copyright 2011 The Go Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style 2 // Use of this source code is governed by a BSD-style
3 // license that can be found in the LICENSE file. 3 // license that can be found in the LICENSE file.
4 4
5 package main 5 package main
6 6
7 import ( 7 import (
8 "bytes" 8 "bytes"
9 "encoding/xml" 9 "encoding/xml"
10 "flag" 10 "flag"
(...skipping 19 matching lines...) Expand all
30 ) 30 )
31 31
32 // These variables are copied from the gobuilder's environment 32 // These variables are copied from the gobuilder's environment
33 // to the envv of its subprocesses. 33 // to the envv of its subprocesses.
34 var extraEnv = []string{ 34 var extraEnv = []string{
35 "GOARM", 35 "GOARM",
36 "GOHOSTARCH", 36 "GOHOSTARCH",
37 "GOHOSTOS", 37 "GOHOSTOS",
38 "PATH", 38 "PATH",
39 "TMPDIR", 39 "TMPDIR",
40 "CC",
minux1 2012/11/18 22:13:16 this array is sorted previously, i think you'd bet
dave_cheney.net 2012/11/19 08:32:12 Done.
40 } 41 }
41 42
42 type Builder struct { 43 type Builder struct {
43 name string 44 name string
44 goos, goarch string 45 goos, goarch string
45 key string 46 key string
46 } 47 }
47 48
48 var ( 49 var (
49 buildroot = flag.String("buildroot", defaultBuildRoot(), "Directory under which to build") 50 buildroot = flag.String("buildroot", defaultBuildRoot(), "Directory under which to build")
(...skipping 643 matching lines...) Expand 10 before | Expand all | Expand 10 after
693 if kv == keq { 694 if kv == keq {
694 return "", true 695 return "", true
695 } 696 }
696 } 697 }
697 return "", false 698 return "", false
698 } 699 }
699 700
700 func hgCmd(args ...string) []string { 701 func hgCmd(args ...string) []string {
701 return append([]string{"hg", "--config", "extensions.codereview=!"}, arg s...) 702 return append([]string{"hg", "--config", "extensions.codereview=!"}, arg s...)
702 } 703 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b