Issue 6843068: code review 6843068: dashboard/builder: pass $CC to builder if set

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6843068: code review 6843068: dashboard/builder: pass $CC to builder if set (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by dfc

Modified:
11 years, 4 months ago

Reviewers:

CC:
adg, minux1, rsc, golang-dev

Visibility:
Public.

Description

dashboard/builder: pass $CC to builder if set

Patch Set 2 : diff -r 9544314de8e8 https://code.google.com/p/go #

Patch Set 3 : diff -r 9544314de8e8 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 852ee39cc8c4 https://code.google.com/p/go #

Patch Set 5 : diff -r be66ed00e1a0 https://go.googlecode.com/hg/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	misc/dashboard/builder/main.go	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

dfc

Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 5 months ago (2012-11-16 04:42:36 UTC) #1

minux1

https://codereview.appspot.com/6843068/diff/4001/misc/dashboard/builder/main.go File misc/dashboard/builder/main.go (right): https://codereview.appspot.com/6843068/diff/4001/misc/dashboard/builder/main.go#newcode40 misc/dashboard/builder/main.go:40: "CC", this array is sorted previously, i think you'd ...

11 years, 5 months ago (2012-11-18 22:13:15 UTC) #3

dfc

PTAL. https://codereview.appspot.com/6843068/diff/4001/misc/dashboard/builder/main.go File misc/dashboard/builder/main.go (right): https://codereview.appspot.com/6843068/diff/4001/misc/dashboard/builder/main.go#newcode40 misc/dashboard/builder/main.go:40: "CC", On 2012/11/18 22:13:16, minux wrote: > this ...

11 years, 5 months ago (2012-11-19 08:32:12 UTC) #4

dfc

11 years, 5 months ago (2012-11-21 21:41:38 UTC) #7

*** Submitted as http://code.google.com/p/go/source/detail?r=6cee245eb194 ***

dashboard/builder: pass $CC to builder if set

R=adg, minux.ma, rsc
CC=golang-dev
http://codereview.appspot.com/6843068

Expand All Messages | Collapse All Messages