Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(38)

Issue 6842121: Add CompleteCredentialsFromEnv tests, cleanup (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 4 months ago by wallyworld
Modified:
8 years, 4 months ago
Reviewers:
mp+137105
Visibility:
Public.

Description

Add CompleteCredentialsFromEnv tests, cleanup CompleteCredentialsFromEnv did not have any test coverage so add some tests. Also clean up how errors are handled in the various service clients based on advice from a code review. https://code.launchpad.net/~wallyworld/goose/add-credentials-test/+merge/137105 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add CompleteCredentialsFromEnv tests, cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -14 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M glance/glance.go View 3 chunks +12 lines, -3 lines 0 comments Download
M identity/identity_test.go View 1 chunk +36 lines, -0 lines 0 comments Download
M nova/nova.go View 11 chunks +44 lines, -11 lines 0 comments Download

Messages

Total messages: 3
wallyworld
Please take a look.
8 years, 4 months ago (2012-11-30 02:08:52 UTC) #1
dimitern
On 2012/11/30 02:08:52, wallyworld wrote: > Please take a look. LGTM
8 years, 4 months ago (2012-11-30 09:33:12 UTC) #2
wallyworld
8 years, 4 months ago (2012-11-30 11:30:46 UTC) #3
*** Submitted:

Add CompleteCredentialsFromEnv tests, cleanup

CompleteCredentialsFromEnv did not have any test coverage so add some tests.
Also clean up how errors are handled in the various service clients based on
advice from a code review.

R=dimitern
CC=
https://codereview.appspot.com/6842121
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b