Issue 6842121: Add CompleteCredentialsFromEnv tests, cleanup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6842121: Add CompleteCredentialsFromEnv tests, cleanup (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by wallyworld

Modified:
11 years, 4 months ago

Reviewers:
mp+137105

Visibility:
Public.

Description

Add CompleteCredentialsFromEnv tests, cleanup CompleteCredentialsFromEnv did not have any test coverage so add some tests. Also clean up how errors are handled in the various service clients based on advice from a code review. https://code.launchpad.net/~wallyworld/goose/add-credentials-test/+merge/137105 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add CompleteCredentialsFromEnv tests, cleanup #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -14 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	glance/glance.go	View	3 chunks	+12 lines, -3 lines	0 comments	Download
M	identity/identity_test.go	View	1 chunk	+36 lines, -0 lines	0 comments	Download
M	nova/nova.go	View	11 chunks	+44 lines, -11 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dimitern

On 2012/11/30 02:08:52, wallyworld wrote: > Please take a look. LGTM

11 years, 4 months ago (2012-11-30 09:33:12 UTC) #2

wallyworld

11 years, 4 months ago (2012-11-30 11:30:46 UTC) #3

*** Submitted:

Add CompleteCredentialsFromEnv tests, cleanup

CompleteCredentialsFromEnv did not have any test coverage so add some tests.
Also clean up how errors are handled in the various service clients based on
advice from a code review.

R=dimitern
CC=
https://codereview.appspot.com/6842121

Expand All Messages | Collapse All Messages