Replaced charm panel icons with our assets.

Replaced charm panel icons with our assets.

In the charm panel, replaced bootstrap icons with
the ones from our sprite. Also added the back triangle
to the sprite.
This branch also fixes the charm menu chevrons: now they
are correctly replaced on panel open/close.
Added "docstrings" for relevant methods.

https://code.launchpad.net/~frankban/juju-gui/bug-1075672-icons/+merge/133944

(do not edit description out of merge proposal)

[frankban, 2012-11-12 15:23:29]

Please take a look.

[teknico, 2012-11-12 15:52:20]

LGTM, nothing to add.

[bac, 2012-11-12 18:28:34]

Thanks Francesco.  I'm concerned about being able to repeatedly open and close
the Charms panel using the top-level twisty.

Otherwise, looks good.

https://codereview.appspot.com/6819131/diff/1/app/templates/charm-description...
File app/templates/charm-description.handlebars (right):

https://codereview.appspot.com/6819131/diff/1/app/templates/charm-description...
app/templates/charm-description.handlebars:15: <h4 class="first"><i
class="sprite chevron_up"></i> Description</h4>
I find chevron-up vs -down counter intuitive but it matches the visual design.

Also I note with your branch that after loading I can click on the Charms icon
at the top and have it work exactly once.  If I close it I cannot reopen. 
Please check that behavior in your branch before submitting.

Additionally it doesn't look like the chevron twists for the top Charms label.

[frankban, 2012-11-13 09:56:49]

On 2012/11/12 18:28:34, bac wrote:
> Thanks Francesco.  I'm concerned about being able to repeatedly open and close
> the Charms panel using the top-level twisty.
> 
> Otherwise, looks good.

Thanks for the review Brad.

> 
>
https://codereview.appspot.com/6819131/diff/1/app/templates/charm-description...
> File app/templates/charm-description.handlebars (right):
> 
>
https://codereview.appspot.com/6819131/diff/1/app/templates/charm-description...
> app/templates/charm-description.handlebars:15: <h4 class="first"><i
> class="sprite chevron_up"></i> Description</h4>
> I find chevron-up vs -down counter intuitive but it matches the visual design.

Agreed.

> 
> Also I note with your branch that after loading I can click on the Charms icon
> at the top and have it work exactly once.  If I close it I cannot reopen. 
> Please check that behavior in your branch before submitting.

Works for me locally, after cleaning the browser cache.

> Additionally it doesn't look like the chevron twists for the top Charms label.

They are correctly replaced here. :-/ I think some kind of cache is hitting us.

[frankban, 2012-11-13 10:00:53]

*** Submitted:

Replaced charm panel icons with our assets.

In the charm panel, replaced bootstrap icons with
the ones from our sprite. Also added the back triangle
to the sprite.
This branch also fixes the charm menu chevrons: now they
are correctly replaced on panel open/close.
Added "docstrings" for relevant methods.

R=teknico, bac
CC=
https://codereview.appspot.com/6819131