Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(548)

Issue 6819131: Replaced charm panel icons with our assets.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 5 months ago by frankban
Modified:
8 years, 5 months ago
Reviewers:
mp+133944, teknico
Visibility:
Public.

Description

Replaced charm panel icons with our assets. In the charm panel, replaced bootstrap icons with the ones from our sprite. Also added the back triangle to the sprite. This branch also fixes the charm menu chevrons: now they are correctly replaced on panel open/close. Added "docstrings" for relevant methods. https://code.launchpad.net/~frankban/juju-gui/bug-1075672-icons/+merge/133944 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Replaced charm panel icons with our assets. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -20 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
A app/assets/images/back_triangle.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M app/index.html View 1 chunk +1 line, -1 line 0 comments Download
M app/templates/charm-description.handlebars View 5 chunks +5 lines, -5 lines 0 comments Download
M app/templates/charm-pre-configuration.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M app/views/charm-panel.js View 6 chunks +29 lines, -7 lines 0 comments Download
M lib/views/stylesheet.less View 2 chunks +2 lines, -1 line 0 comments Download
M test/test_charm_panel.js View 1 chunk +3 lines, -3 lines 0 comments Download
M undocumented View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
8 years, 5 months ago (2012-11-12 15:23:29 UTC) #1
teknico
LGTM, nothing to add.
8 years, 5 months ago (2012-11-12 15:52:20 UTC) #2
bac
Thanks Francesco. I'm concerned about being able to repeatedly open and close the Charms panel ...
8 years, 5 months ago (2012-11-12 18:28:34 UTC) #3
frankban
On 2012/11/12 18:28:34, bac wrote: > Thanks Francesco. I'm concerned about being able to repeatedly ...
8 years, 5 months ago (2012-11-13 09:56:49 UTC) #4
frankban
8 years, 5 months ago (2012-11-13 10:00:53 UTC) #5
*** Submitted:

Replaced charm panel icons with our assets.

In the charm panel, replaced bootstrap icons with
the ones from our sprite. Also added the back triangle
to the sprite.
This branch also fixes the charm menu chevrons: now they
are correctly replaced on panel open/close.
Added "docstrings" for relevant methods.

R=teknico, bac
CC=
https://codereview.appspot.com/6819131
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b