Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(292)

Issue 6812089: code review 6812089: cmd/gc: don't require that slice index constants be sma... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by iant
Modified:
9 years, 9 months ago
Reviewers:
CC:
remyoudompheng, rsc, golang-dev
Visibility:
Public.

Description

cmd/gc: don't require that slice index constants be small ints The test for this is test/index.go, which is not run by default.

Patch Set 1 #

Patch Set 2 : diff -r 45cd940d4b21 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/cmd/gc/walk.c View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
iant
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 9 months ago (2012-11-06 00:53:06 UTC) #1
remyoudompheng
LGTM
9 years, 9 months ago (2012-11-06 07:05:51 UTC) #2
rsc
I think for even larger constants mpgetfix may return -1, so those might need a ...
9 years, 9 months ago (2012-11-06 18:53:00 UTC) #3
iant
9 years, 9 months ago (2012-11-06 19:37:02 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=67a654caa462 ***

cmd/gc: don't require that slice index constants be small ints

The test for this is test/index.go, which is not run by
default.

R=remyoudompheng, rsc
CC=golang-dev
http://codereview.appspot.com/6812089
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b