Issue 6812089: code review 6812089: cmd/gc: don't require that slice index constants be sma...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6812089: code review 6812089: cmd/gc: don't require that slice index constants be sma... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by iant

Modified:
11 years, 5 months ago

Reviewers:

CC:
remyoudompheng, rsc, golang-dev

Visibility:
Public.

Description

cmd/gc: don't require that slice index constants be small ints The test for this is test/index.go, which is not run by default.

Patch Set 1 #

Patch Set 2 : diff -r 45cd940d4b21 https://go.googlecode.com/hg/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/cmd/gc/walk.c	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

iant

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 5 months ago (2012-11-06 00:53:06 UTC) #1

rsc

I think for even larger constants mpgetfix may return -1, so those might need a ...

11 years, 5 months ago (2012-11-06 18:53:00 UTC) #3

iant

11 years, 5 months ago (2012-11-06 19:37:02 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=67a654caa462 ***

cmd/gc: don't require that slice index constants be small ints

The test for this is test/index.go, which is not run by
default.

R=remyoudompheng, rsc
CC=golang-dev
http://codereview.appspot.com/6812089

Expand All Messages | Collapse All Messages