Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(228)

Issue 6782078: code review 6782078: go.net/proxy: fix IP address determination (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by mikio
Modified:
9 years, 6 months ago
Reviewers:
CC:
agl1, dfc, golang-dev
Visibility:
Public.

Description

go.net/proxy: fix IP address determination net.IP represents either an IPv4 or IPv6 address. In case of the address of IPv4 node, it uses IPv4-mapped IPv6 address format by default.

Patch Set 1 #

Patch Set 2 : diff -r c86d1f439e36 https://code.google.com/p/go.net #

Patch Set 3 : diff -r c86d1f439e36 https://code.google.com/p/go.net #

Patch Set 4 : diff -r c86d1f439e36 https://code.google.com/p/go.net #

Patch Set 5 : diff -r c86d1f439e36 https://code.google.com/p/go.net #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M proxy/socks5.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
mikio
Hello agl@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net
9 years, 6 months ago (2012-11-16 10:50:14 UTC) #1
dfc
On 2012/11/16 10:50:14, mikio wrote: > Hello mailto:agl@golang.org (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...
9 years, 6 months ago (2012-11-16 10:57:57 UTC) #2
mikio
On Fri, Nov 16, 2012 at 7:57 PM, <dave@cheney.net> wrote: > Change LGTM, but not ...
9 years, 6 months ago (2012-11-16 11:22:22 UTC) #3
mikio
Hello agl@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2012-11-16 11:22:46 UTC) #4
agl1
Surprising behaviour from net, but LGTM.
9 years, 6 months ago (2012-11-16 15:07:04 UTC) #5
mikio
9 years, 6 months ago (2012-11-17 05:35:58 UTC) #6
*** Submitted as
http://code.google.com/p/go/source/detail?r=838dac337e60&repo=net ***

go.net/proxy: fix IP address determination

net.IP represents either an IPv4 or IPv6 address. In case of
the address of IPv4 node, it uses IPv4-mapped IPv6 address
format by default.

R=agl, dave
CC=golang-dev
http://codereview.appspot.com/6782078
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b