code review 6782078: go.net/proxy: fix IP address determination

go.net/proxy: fix IP address determination

net.IP represents either an IPv4 or IPv6 address. In case of
the address of IPv4 node, it uses IPv4-mapped IPv6 address
format by default.

[mikio, 2012-11-16 10:50:14]

Hello agl@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.net

[dfc, 2012-11-16 10:57:57]

On 2012/11/16 10:50:14, mikio wrote:
> Hello mailto:agl@golang.org (cc: mailto:golang-dev@googlegroups.com),
> 
> I'd like you to review this change to
> https://code.google.com/p/go.net

Change LGTM, but not the description. I thought that net.IP represented either
an IPv4 or IPv6 address. To me, IPv4 mapped IPv6 talks about the ::ffff: range.

[mikio, 2012-11-16 11:22:22]

On Fri, Nov 16, 2012 at 7:57 PM,  <dave@cheney.net> wrote:

> Change LGTM, but not the description. I thought that net.IP represented
> either an IPv4 or IPv6 address.

Yup.

> To me, IPv4 mapped IPv6 talks about the ::ffff: range.

It represents an IPv4 address of IPv4 node as IPv6 address, surely.
::fff:0:0:0:0/96 is just a format of address, but net.IP uses that.

[mikio, 2012-11-16 11:22:46]

Hello agl@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com),

Please take another look.

[agl1, 2012-11-16 15:07:04]

Surprising behaviour from net, but LGTM.

[mikio, 2012-11-17 05:35:58]

*** Submitted as
http://code.google.com/p/go/source/detail?r=838dac337e60&repo=net ***

go.net/proxy: fix IP address determination

net.IP represents either an IPv4 or IPv6 address. In case of
the address of IPv4 node, it uses IPv4-mapped IPv6 address
format by default.

R=agl, dave
CC=golang-dev
http://codereview.appspot.com/6782078