Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(930)

Issue 6639062: code review 6639062: tour: Internationaliztion of the user interface (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by jeff.allen
Modified:
9 years, 11 months ago
Reviewers:
CC:
golang-dev, adg
Visibility:
Public.

Description

tour: Internationaliztion of the user interface With this change, translators no longer need to muck about in tour.js. They need only edit index.html.

Patch Set 1 #

Patch Set 2 : diff -r e3153ab31a06 https://code.google.com/p/go-tour #

Patch Set 3 : diff -r e3153ab31a06 https://code.google.com/p/go-tour #

Patch Set 4 : diff -r e3153ab31a06 https://code.google.com/p/go-tour #

Patch Set 5 : diff -r e3153ab31a06 https://code.google.com/p/go-tour #

Total comments: 1

Patch Set 6 : diff -r f46743ab58c3 https://code.google.com/p/go-tour #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -11 lines) Patch
M static/index.html View 1 2 3 4 5 1 chunk +18 lines, -0 lines 0 comments Download
M static/tour.js View 1 2 3 4 5 11 chunks +32 lines, -11 lines 0 comments Download

Messages

Total messages: 9
jeff.allen
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go-tour
10 years, 1 month ago (2012-10-10 23:03:23 UTC) #1
adg
Thanks, but there are some things I don't like about this change: a) adds another ...
10 years, 1 month ago (2012-10-10 23:41:18 UTC) #2
jeff.allen
Translations should not be mixed with code. But a good compromise would be to put ...
10 years, 1 month ago (2012-10-11 06:43:38 UTC) #3
adg
On 2012/10/11 06:43:38, jeff.allen wrote: > Translations should not be mixed with code. But a ...
10 years, 1 month ago (2012-10-11 06:50:43 UTC) #4
jeff.allen
Hello golang-dev@googlegroups.com, adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 1 month ago (2012-10-16 20:37:37 UTC) #5
adg
This is better. Thanks. https://codereview.appspot.com/6639062/diff/14001/static/index.html File static/index.html (right): https://codereview.appspot.com/6639062/diff/14001/static/index.html#newcode20 static/index.html:20: // Put your translation of ...
10 years, 1 month ago (2012-10-19 00:41:18 UTC) #6
jeff.allen
Hello golang-dev@googlegroups.com, adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years ago (2012-12-07 20:16:35 UTC) #7
adg
LGTM
9 years, 12 months ago (2012-12-10 04:23:20 UTC) #8
adg
9 years, 12 months ago (2012-12-10 04:27:07 UTC) #9
*** Submitted as https://code.google.com/p/go-tour/source/detail?r=9f2b64a094e5
***

tour: Internationaliztion of the user interface

With this change, translators no longer need to muck about
in tour.js. They need only edit index.html.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/6639062

Committer: Andrew Gerrand <adg@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b