code review 6639062: tour: Internationaliztion of the user interface

tour: Internationaliztion of the user interface

With this change, translators no longer need to muck about
in tour.js. They need only edit index.html.

[jeff.allen, 2012-10-10 23:03:23]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go-tour

[adg, 2012-10-10 23:41:18]

Thanks, but there are some things I don't like about this change:

a) adds another js file to load; please put the translation map in tour.js
b) the keys for the lang map should not be the english sentences, but rather
short keywords that describe the various strings. then there should be a default
english mapping.

[jeff.allen, 2012-10-11 06:43:38]

Translations should not be mixed with code. But a good compromise would be to
put it in index.html. Your other suggestion loses the default to english whichis
 too bad.

[adg, 2012-10-11 06:50:43]

On 2012/10/11 06:43:38, jeff.allen wrote:
> Translations should not be mixed with code. But a good compromise would be to
> put it in index.html. Your other suggestion loses the default to english
whichis
>  too bad.

I'm not even clear how the translations will be swapped in, so it makes no
difference whether it's in lang.js or tour.js right now.

[jeff.allen, 2012-10-16 20:37:37]

Hello golang-dev@googlegroups.com, adg@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[adg, 2012-10-19 00:41:18]

This is better. Thanks.

https://codereview.appspot.com/6639062/diff/14001/static/index.html
File static/index.html (right):

https://codereview.appspot.com/6639062/diff/14001/static/index.html#newcode20
static/index.html:20: // Put your translation of the user interface here.
// Localized user interface.

[jeff.allen, 2012-12-07 20:16:35]

Hello golang-dev@googlegroups.com, adg@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[adg, 2012-12-10 04:23:20]

LGTM

[adg, 2012-12-10 04:27:07]

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=9f2b64a094e5
***

tour: Internationaliztion of the user interface

With this change, translators no longer need to muck about
in tour.js. They need only edit index.html.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/6639062

Committer: Andrew Gerrand <adg@golang.org>