Issue 6598052: gnuflag: implement = in flags.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6598052: gnuflag: implement = in flags.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rog

Modified:
11 years, 6 months ago

Reviewers:
mp+127469

Visibility:
Public.

Description

gnuflag: implement = in flags. We should be pretty close to compatible with all GNU flag usage now. https://code.launchpad.net/~rogpeppe/gnuflag/support-equals/+merge/127469 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : gnuflag: implement = in flags. #

Patch Set 3 : gnuflag: implement = in flags. #

Patch Set 4 : gnuflag: implement = in flags. #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+260 lines, -172 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	flag.go	View	1 2	7 chunks	+36 lines, -12 lines	0 comments	Download
M	flag_test.go	View	1 2	2 chunks	+222 lines, -160 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dave_cheney.net

On 2012/10/02 12:27:23, rog wrote: > Please take a look. LGTM, nice tests. Thanks.

11 years, 6 months ago (2012-10-02 13:16:21 UTC) #2

rog

i've changed it now, based on your remarks from your original CL. -x=foo is different ...

11 years, 6 months ago (2012-10-02 14:10:46 UTC) #4

rog

11 years, 6 months ago (2012-10-03 09:34:40 UTC) #5

*** Submitted:

gnuflag: implement = in flags.

We should be pretty close to compatible with
all GNU flag usage now.

R=dfc
CC=
https://codereview.appspot.com/6598052

Expand All Messages | Collapse All Messages