Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1661)

Issue 6598052: gnuflag: implement = in flags.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by rog
Modified:
7 years, 11 months ago
Reviewers:
mp+127469
Visibility:
Public.

Description

gnuflag: implement = in flags. We should be pretty close to compatible with all GNU flag usage now. https://code.launchpad.net/~rogpeppe/gnuflag/support-equals/+merge/127469 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : gnuflag: implement = in flags. #

Patch Set 3 : gnuflag: implement = in flags. #

Patch Set 4 : gnuflag: implement = in flags. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -172 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M flag.go View 1 2 7 chunks +36 lines, -12 lines 0 comments Download
M flag_test.go View 1 2 2 chunks +222 lines, -160 lines 0 comments Download

Messages

Total messages: 5
rog
Please take a look.
7 years, 11 months ago (2012-10-02 12:27:23 UTC) #1
dfc
On 2012/10/02 12:27:23, rog wrote: > Please take a look. LGTM, nice tests. Thanks.
7 years, 11 months ago (2012-10-02 13:16:21 UTC) #2
rog
Please take a look.
7 years, 11 months ago (2012-10-02 14:07:32 UTC) #3
rog
i've changed it now, based on your remarks from your original CL. -x=foo is different ...
7 years, 11 months ago (2012-10-02 14:10:46 UTC) #4
rog
7 years, 11 months ago (2012-10-03 09:34:40 UTC) #5
*** Submitted:

gnuflag: implement = in flags.

We should be pretty close to compatible with
all GNU flag usage now.

R=dfc
CC=
https://codereview.appspot.com/6598052
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b