Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1391)

Issue 6567054: cmd/builddb: tweaks for new state

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by niemeyer
Modified:
10 years, 2 months ago
Reviewers:
mp+126537, fwereade
Visibility:
Public.

Description

cmd/builddb: tweaks for new state This also moves it from util/ to cmd/, which is fine now that environs is building tools explicitly by their name when shipping to an environment. util/ is gone. https://code.launchpad.net/~niemeyer/juju-core/new-state-builddb/+merge/126537 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/builddb: tweaks for new state #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/builddb/main.go View 2 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 5
niemeyer
Please take a look.
10 years, 2 months ago (2012-09-26 20:18:55 UTC) #1
fwereade
LGTM (Hmm, I'm really starting to feel that it was a bad idea to made ...
10 years, 2 months ago (2012-09-26 20:31:53 UTC) #2
niemeyer
On 2012/09/26 20:31:53, fwereade wrote: > LGTM > > (Hmm, I'm really starting to feel ...
10 years, 2 months ago (2012-09-26 23:22:06 UTC) #3
niemeyer
On 2012/09/26 23:22:06, niemeyer wrote: > On 2012/09/26 20:31:53, fwereade wrote: > > LGTM > ...
10 years, 2 months ago (2012-09-26 23:23:08 UTC) #4
niemeyer
10 years, 2 months ago (2012-09-26 23:25:22 UTC) #5
*** Submitted:

cmd/builddb: tweaks for new state

This also moves it from util/ to cmd/, which is fine now that
environs is building tools explicitly by their name when
shipping to an environment. util/ is gone.

R=fwereade
CC=
https://codereview.appspot.com/6567054
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b