cmd/builddb: tweaks for new state

cmd/builddb: tweaks for new state

This also moves it from util/ to cmd/, which is fine now that
environs is building tools explicitly by their name when
shipping to an environment. util/ is gone.

https://code.launchpad.net/~niemeyer/juju-core/new-state-builddb/+merge/126537

(do not edit description out of merge proposal)

[niemeyer, 2012-09-26 20:18:55]

Please take a look.

[fwereade, 2012-09-26 20:31:53]

LGTM

(Hmm, I'm really starting to feel that it was a bad idea to made Status depend
on unit liveness... they should be separated, and we should fix the status
command so that it's responsible for showing dead agents; then you could use an
actual unit watcher instead of polling.)

[niemeyer, 2012-09-26 23:22:06]

On 2012/09/26 20:31:53, fwereade wrote:
> LGTM
> 
> (Hmm, I'm really starting to feel that it was a bad idea to made Status depend
> on unit liveness... they should be separated, and we should fix the status
> command so that it's responsible for showing dead agents; then you could use
an
> actual unit watcher instead of polling.)

+1 on separating somehow.

For watching, I actually think we need a sort of unit.Wait(timeout) method, so
that we can use it from a "juju wait" command.

[niemeyer, 2012-09-26 23:23:08]

On 2012/09/26 23:22:06, niemeyer wrote:
> On 2012/09/26 20:31:53, fwereade wrote:
> > LGTM
> > 
> > (Hmm, I'm really starting to feel that it was a bad idea to made Status
depend
> > on unit liveness... they should be separated, and we should fix the status
> > command so that it's responsible for showing dead agents; then you could use
> an
> > actual unit watcher instead of polling.)
> 
> +1 on separating somehow.
> 
> For watching, I actually think we need a sort of unit.Wait(timeout) method, so
> that we can use it from a "juju wait" command.

Perhaps more properly:

     info, err := unit.Wait(status, timeout)

Built in terms of the unit watcher.

[niemeyer, 2012-09-26 23:25:22]

*** Submitted:

cmd/builddb: tweaks for new state

This also moves it from util/ to cmd/, which is fine now that
environs is building tools explicitly by their name when
shipping to an environment. util/ is gone.

R=fwereade
CC=
https://codereview.appspot.com/6567054