Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(67)

Issue 6498101: code review 6498101: 6g: delete unnecessary OXXX initialization. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by nigeltao
Modified:
10 years ago
Reviewers:
CC:
remy_archlinux.org, r, golang-dev, rsc
Visibility:
Public.

Description

6g: delete unnecessary OXXX initialization. No longer necessary after https://codereview.appspot.com/6497073/ removed the `if(n5.op != OXXX) { regfree(&n5); }`.

Patch Set 1 #

Patch Set 2 : diff -r a76067712fe9 https://code.google.com/p/go #

Patch Set 3 : diff -r a76067712fe9 https://code.google.com/p/go #

Patch Set 4 : diff -r 7047e253f1cd https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/cmd/6g/cgen.c View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3
nigeltao
Hello remy@archlinux.org (cc: golang-dev@googlegroups.com, rsc@golang.org), I'd like you to review this change to https://code.google.com/p/go
10 years ago (2012-09-07 06:03:04 UTC) #1
r
LGTM
10 years ago (2012-09-07 06:26:29 UTC) #2
nigeltao
10 years ago (2012-09-10 01:24:51 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=9e5a84e0fa57 ***

6g: delete unnecessary OXXX initialization.

No longer necessary after https://codereview.appspot.com/6497073/
removed the `if(n5.op != OXXX) { regfree(&n5); }`.

R=remy, r
CC=golang-dev, rsc
http://codereview.appspot.com/6498101
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b