Issue 6498101: code review 6498101: 6g: delete unnecessary OXXX initialization.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6498101: code review 6498101: 6g: delete unnecessary OXXX initialization. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by nigeltao

Modified:
11 years, 7 months ago

Reviewers:

CC:
remy_archlinux.org, r, golang-dev, rsc

Visibility:
Public.

Description

6g: delete unnecessary OXXX initialization. No longer necessary after https://codereview.appspot.com/6497073/ removed the `if(n5.op != OXXX) { regfree(&n5); }`.

Patch Set 1 #

Patch Set 2 : diff -r a76067712fe9 https://code.google.com/p/go #

Patch Set 3 : diff -r a76067712fe9 https://code.google.com/p/go #

Patch Set 4 : diff -r 7047e253f1cd https://code.google.com/p/go #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	src/cmd/6g/cgen.c	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello remy@archlinux.org (cc: golang-dev@googlegroups.com, rsc@golang.org), I'd like you to review this change to https://code.google.com/p/go

11 years, 7 months ago (2012-09-07 06:03:04 UTC) #1

nigeltao

11 years, 7 months ago (2012-09-10 01:24:51 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=9e5a84e0fa57 ***

6g: delete unnecessary OXXX initialization.

No longer necessary after https://codereview.appspot.com/6497073/
removed the `if(n5.op != OXXX) { regfree(&n5); }`.

R=remy, r
CC=golang-dev, rsc
http://codereview.appspot.com/6498101

Expand All Messages | Collapse All Messages