Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(126)

Issue 6495090: code review 6495090: cgo: use debug data section for ELF (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by jsing
Modified:
9 years, 9 months ago
Reviewers:
dfc, albert.strasheim
CC:
golang-dev, minux1
Visibility:
Public.

Description

cgo: use debug data section for ELF When generating enums use the debug data section instead of the DWARF debug info, if it is available in the ELF file. This allows mkerrors.sh to work correctly on OpenBSD/386 and NetBSD/386. Fixes issue 2470.

Patch Set 1 #

Patch Set 2 : diff -r df382f6986cf https://go.googlecode.com/hg #

Patch Set 3 : diff -r df382f6986cf https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 95fb3bcdc941 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M src/cmd/cgo/gcc.go View 1 2 chunks +26 lines, -7 lines 0 comments Download

Messages

Total messages: 9
jsing
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 9 months ago (2012-09-06 13:20:12 UTC) #1
minux1
LGTM, also tested on darwin/arm which is also affected by issue 2470.
9 years, 9 months ago (2012-09-06 16:33:35 UTC) #2
jsing
*** Submitted as http://code.google.com/p/go/source/detail?r=41976e2fec9b *** cgo: use debug data section for ELF When generating enums ...
9 years, 9 months ago (2012-09-07 03:33:02 UTC) #3
albert.strasheim
Hello Unfortunately this change broke stuff for us. If you have two .go files in ...
9 years, 9 months ago (2012-09-07 06:31:11 UTC) #4
dfc
Urk, this sounds serious. fullung, could you please log an issue with a simple test ...
9 years, 9 months ago (2012-09-07 06:36:02 UTC) #5
albert.strasheim
Hello Seems related to enums. Working on reducing a test case now. Quite tricky. Cheers ...
9 years, 9 months ago (2012-09-07 07:00:21 UTC) #6
albert.strasheim
http://code.google.com/p/go/issues/detail?id=4054 On Fri, Sep 7, 2012 at 9:00 AM, Albert Strasheim <fullung@gmail.com> wrote: > Hello ...
9 years, 9 months ago (2012-09-07 09:00:59 UTC) #7
jsing
On 7 September 2012 19:00, Albert Strasheim <fullung@gmail.com> wrote: > http://code.google.com/p/go/issues/detail?id=4054 Thanks for the report ...
9 years, 9 months ago (2012-09-07 11:50:37 UTC) #8
jsing
9 years, 9 months ago (2012-09-07 12:55:13 UTC) #9
On 7 September 2012 21:50, Joel Sing <jsing@google.com> wrote:
> On 7 September 2012 19:00, Albert Strasheim <fullung@gmail.com> wrote:
>> http://code.google.com/p/go/issues/detail?id=4054
>
> Thanks for the report and the test case. This is not expected and I
> should have a fix soon.

Should be fixed by:

http://codereview.appspot.com/6501101

>> On Fri, Sep 7, 2012 at 9:00 AM, Albert Strasheim <fullung@gmail.com> wrote:
>>> Hello
>>>
>>> Seems related to enums. Working on reducing a test case now. Quite tricky.
>>>
>>> Cheers
>>>
>>> Albert
>>>
>>>
>>> On Friday, September 7, 2012 8:36:04 AM UTC+2, Dave Cheney wrote:
>>>>
>>>> Urk, this sounds serious. fullung, could you please log an issue with
>>>> a simple test case (assuming you haven't already done so)
>>>>
>>>> On Fri, Sep 7, 2012 at 4:31 PM,  <ful...@gmail.com> wrote:
>>>> > Hello
>>>> >
>>>> > Unfortunately this change broke stuff for us.
>>>> >
>>>> > If you have two .go files in the same package that use the same
>>>> > C.SOMETHING constant, your build fails with:
>>>> >
>>>> > inconsistent definitions for C.SOMETHING
>>>> >
>>>> > One way to work around this is to define a const in one file, but maybe
>>>> > it wasn't intended to break?
>>>> >
>>>> > Regards,
>>>> >
>>>> > Albert
>>>> >
>>>> >
>>>> > On 2012/09/07 03:33:02, jsing wrote:
>>>> >>
>>>> >> *** Submitted as
>>>> >
>>>> > http://code.google.com/p/go/source/detail?r=41976e2fec9b ***
>>>> >
>>>> >> cgo: use debug data section for ELF
>>>> >
>>>> >
>>>> >> When generating enums use the debug data section instead of the
>>>> >> DWARF debug info, if it is available in the ELF file. This allows
>>>> >> mkerrors.sh to work correctly on OpenBSD/386 and NetBSD/386.
>>>> >
>>>> >
>>>> >> Fixes issue 2470.
>>>> >
>>>> >
>>>> >> R=golang-dev, minux.ma
>>>> >> CC=golang-dev
>>>> >> http://codereview.appspot.com/6495090
>>>> >
>>>> >
>>>> > http://codereview.appspot.com/6495090/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b