code review 6495090: cgo: use debug data section for ELF

cgo: use debug data section for ELF

When generating enums use the debug data section instead of the
DWARF debug info, if it is available in the ELF file. This allows
mkerrors.sh to work correctly on OpenBSD/386 and NetBSD/386.

Fixes issue 2470.

[jsing, 2012-09-06 13:20:12]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[minux1, 2012-09-06 16:33:35]

LGTM, also tested on darwin/arm which is also affected by issue 2470.

[jsing, 2012-09-07 03:33:02]

*** Submitted as http://code.google.com/p/go/source/detail?r=41976e2fec9b ***

cgo: use debug data section for ELF

When generating enums use the debug data section instead of the
DWARF debug info, if it is available in the ELF file. This allows
mkerrors.sh to work correctly on OpenBSD/386 and NetBSD/386.

Fixes issue 2470.

R=golang-dev, minux.ma
CC=golang-dev
http://codereview.appspot.com/6495090

[albert.strasheim, 2012-09-07 06:31:11]

Hello

Unfortunately this change broke stuff for us.

If you have two .go files in the same package that use the same C.SOMETHING
constant, your build fails with:

inconsistent definitions for C.SOMETHING

One way to work around this is to define a const in one file, but maybe it
wasn't intended to break?

Regards,

Albert

On 2012/09/07 03:33:02, jsing wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=41976e2fec9b ***
> 
> cgo: use debug data section for ELF
> 
> When generating enums use the debug data section instead of the
> DWARF debug info, if it is available in the ELF file. This allows
> mkerrors.sh to work correctly on OpenBSD/386 and NetBSD/386.
> 
> Fixes issue 2470.
> 
> R=golang-dev, minux.ma
> CC=golang-dev
> http://codereview.appspot.com/6495090

[dave_cheney.net, 2012-09-07 06:36:02]

Urk, this sounds serious. fullung, could you please log an issue with
a simple test case (assuming you haven't already done so)

On Fri, Sep 7, 2012 at 4:31 PM,  <fullung@gmail.com> wrote:
> Hello
>
> Unfortunately this change broke stuff for us.
>
> If you have two .go files in the same package that use the same
> C.SOMETHING constant, your build fails with:
>
> inconsistent definitions for C.SOMETHING
>
> One way to work around this is to define a const in one file, but maybe
> it wasn't intended to break?
>
> Regards,
>
> Albert
>
>
> On 2012/09/07 03:33:02, jsing wrote:
>>
>> *** Submitted as
>
> http://code.google.com/p/go/source/detail?r=41976e2fec9b ***
>
>> cgo: use debug data section for ELF
>
>
>> When generating enums use the debug data section instead of the
>> DWARF debug info, if it is available in the ELF file. This allows
>> mkerrors.sh to work correctly on OpenBSD/386 and NetBSD/386.
>
>
>> Fixes issue 2470.
>
>
>> R=golang-dev, minux.ma
>> CC=golang-dev
>> http://codereview.appspot.com/6495090
>
>
> http://codereview.appspot.com/6495090/

[albert.strasheim, 2012-09-07 07:00:21]

Hello

Seems related to enums. Working on reducing a test case now. Quite tricky.

Cheers

Albert

On Friday, September 7, 2012 8:36:04 AM UTC+2, Dave Cheney wrote:
>
> Urk, this sounds serious. fullung, could you please log an issue with 
> a simple test case (assuming you haven't already done so) 
>
> On Fri, Sep 7, 2012 at 4:31 PM,  <ful...@gmail.com <javascript:>> wrote: 
> > Hello 
> > 
> > Unfortunately this change broke stuff for us. 
> > 
> > If you have two .go files in the same package that use the same 
> > C.SOMETHING constant, your build fails with: 
> > 
> > inconsistent definitions for C.SOMETHING 
> > 
> > One way to work around this is to define a const in one file, but maybe 
> > it wasn't intended to break? 
> > 
> > Regards, 
> > 
> > Albert 
> > 
> > 
> > On 2012/09/07 03:33:02, jsing wrote: 
> >> 
> >> *** Submitted as 
> > 
> > http://code.google.com/p/go/source/detail?r=41976e2fec9b *** 
> > 
> >> cgo: use debug data section for ELF 
> > 
> > 
> >> When generating enums use the debug data section instead of the 
> >> DWARF debug info, if it is available in the ELF file. This allows 
> >> mkerrors.sh to work correctly on OpenBSD/386 and NetBSD/386. 
> > 
> > 
> >> Fixes issue 2470. 
> > 
> > 
> >> R=golang-dev, minux.ma 
> >> CC=golang-dev 
> >> http://codereview.appspot.com/6495090 
> > 
> > 
> > http://codereview.appspot.com/6495090/ 
>

[albert.strasheim, 2012-09-07 09:00:59]

http://code.google.com/p/go/issues/detail?id=4054

On Fri, Sep 7, 2012 at 9:00 AM, Albert Strasheim <fullung@gmail.com> wrote:
> Hello
>
> Seems related to enums. Working on reducing a test case now. Quite tricky.
>
> Cheers
>
> Albert
>
>
> On Friday, September 7, 2012 8:36:04 AM UTC+2, Dave Cheney wrote:
>>
>> Urk, this sounds serious. fullung, could you please log an issue with
>> a simple test case (assuming you haven't already done so)
>>
>> On Fri, Sep 7, 2012 at 4:31 PM,  <ful...@gmail.com> wrote:
>> > Hello
>> >
>> > Unfortunately this change broke stuff for us.
>> >
>> > If you have two .go files in the same package that use the same
>> > C.SOMETHING constant, your build fails with:
>> >
>> > inconsistent definitions for C.SOMETHING
>> >
>> > One way to work around this is to define a const in one file, but maybe
>> > it wasn't intended to break?
>> >
>> > Regards,
>> >
>> > Albert
>> >
>> >
>> > On 2012/09/07 03:33:02, jsing wrote:
>> >>
>> >> *** Submitted as
>> >
>> > http://code.google.com/p/go/source/detail?r=41976e2fec9b ***
>> >
>> >> cgo: use debug data section for ELF
>> >
>> >
>> >> When generating enums use the debug data section instead of the
>> >> DWARF debug info, if it is available in the ELF file. This allows
>> >> mkerrors.sh to work correctly on OpenBSD/386 and NetBSD/386.
>> >
>> >
>> >> Fixes issue 2470.
>> >
>> >
>> >> R=golang-dev, minux.ma
>> >> CC=golang-dev
>> >> http://codereview.appspot.com/6495090
>> >
>> >
>> > http://codereview.appspot.com/6495090/

[jsing, 2012-09-07 11:50:37]

On 7 September 2012 19:00, Albert Strasheim <fullung@gmail.com> wrote:
> http://code.google.com/p/go/issues/detail?id=4054

Thanks for the report and the test case. This is not expected and I
should have a fix soon.

> On Fri, Sep 7, 2012 at 9:00 AM, Albert Strasheim <fullung@gmail.com> wrote:
>> Hello
>>
>> Seems related to enums. Working on reducing a test case now. Quite tricky.
>>
>> Cheers
>>
>> Albert
>>
>>
>> On Friday, September 7, 2012 8:36:04 AM UTC+2, Dave Cheney wrote:
>>>
>>> Urk, this sounds serious. fullung, could you please log an issue with
>>> a simple test case (assuming you haven't already done so)
>>>
>>> On Fri, Sep 7, 2012 at 4:31 PM,  <ful...@gmail.com> wrote:
>>> > Hello
>>> >
>>> > Unfortunately this change broke stuff for us.
>>> >
>>> > If you have two .go files in the same package that use the same
>>> > C.SOMETHING constant, your build fails with:
>>> >
>>> > inconsistent definitions for C.SOMETHING
>>> >
>>> > One way to work around this is to define a const in one file, but maybe
>>> > it wasn't intended to break?
>>> >
>>> > Regards,
>>> >
>>> > Albert
>>> >
>>> >
>>> > On 2012/09/07 03:33:02, jsing wrote:
>>> >>
>>> >> *** Submitted as
>>> >
>>> > http://code.google.com/p/go/source/detail?r=41976e2fec9b ***
>>> >
>>> >> cgo: use debug data section for ELF
>>> >
>>> >
>>> >> When generating enums use the debug data section instead of the
>>> >> DWARF debug info, if it is available in the ELF file. This allows
>>> >> mkerrors.sh to work correctly on OpenBSD/386 and NetBSD/386.
>>> >
>>> >
>>> >> Fixes issue 2470.
>>> >
>>> >
>>> >> R=golang-dev, minux.ma
>>> >> CC=golang-dev
>>> >> http://codereview.appspot.com/6495090
>>> >
>>> >
>>> > http://codereview.appspot.com/6495090/

[jsing, 2012-09-07 12:55:13]

On 7 September 2012 21:50, Joel Sing <jsing@google.com> wrote:
> On 7 September 2012 19:00, Albert Strasheim <fullung@gmail.com> wrote:
>> http://code.google.com/p/go/issues/detail?id=4054
>
> Thanks for the report and the test case. This is not expected and I
> should have a fix soon.

Should be fixed by:

http://codereview.appspot.com/6501101

>> On Fri, Sep 7, 2012 at 9:00 AM, Albert Strasheim <fullung@gmail.com> wrote:
>>> Hello
>>>
>>> Seems related to enums. Working on reducing a test case now. Quite tricky.
>>>
>>> Cheers
>>>
>>> Albert
>>>
>>>
>>> On Friday, September 7, 2012 8:36:04 AM UTC+2, Dave Cheney wrote:
>>>>
>>>> Urk, this sounds serious. fullung, could you please log an issue with
>>>> a simple test case (assuming you haven't already done so)
>>>>
>>>> On Fri, Sep 7, 2012 at 4:31 PM,  <ful...@gmail.com> wrote:
>>>> > Hello
>>>> >
>>>> > Unfortunately this change broke stuff for us.
>>>> >
>>>> > If you have two .go files in the same package that use the same
>>>> > C.SOMETHING constant, your build fails with:
>>>> >
>>>> > inconsistent definitions for C.SOMETHING
>>>> >
>>>> > One way to work around this is to define a const in one file, but maybe
>>>> > it wasn't intended to break?
>>>> >
>>>> > Regards,
>>>> >
>>>> > Albert
>>>> >
>>>> >
>>>> > On 2012/09/07 03:33:02, jsing wrote:
>>>> >>
>>>> >> *** Submitted as
>>>> >
>>>> > http://code.google.com/p/go/source/detail?r=41976e2fec9b ***
>>>> >
>>>> >> cgo: use debug data section for ELF
>>>> >
>>>> >
>>>> >> When generating enums use the debug data section instead of the
>>>> >> DWARF debug info, if it is available in the ELF file. This allows
>>>> >> mkerrors.sh to work correctly on OpenBSD/386 and NetBSD/386.
>>>> >
>>>> >
>>>> >> Fixes issue 2470.
>>>> >
>>>> >
>>>> >> R=golang-dev, minux.ma
>>>> >> CC=golang-dev
>>>> >> http://codereview.appspot.com/6495090
>>>> >
>>>> >
>>>> > http://codereview.appspot.com/6495090/