Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(965)

Issue 6495089: Using the device scale factor for glyph positioning (second approach) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by tdanderson
Modified:
10 years ago
Reviewers:
reed1
CC:
behdad, rjkroege, bungeman, rbyers
Base URL:
http://git.chromium.org/external/skia/src.git@base
Visibility:
Public.

Description

Using the device scale factor for glyph positioning (second approach) The master bug is http://code.google.com/p/chromium/issues/detail?id=138101 . The corresponding WebKit changes for this CL are here: https://bugs.webkit.org/show_bug.cgi?id=96137 Note that the changes in https://codereview.appspot.com/6488085 should also be included in this CL. BUG=

Patch Set 1 #

Patch Set 2 : Modified approach #

Patch Set 3 : Using a build flag #

Patch Set 4 : Using a build flag (disregard patch set 3) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M core/SkPaint.cpp View 1 2 3 8 chunks +33 lines, -0 lines 0 comments Download
M core/SkScalerContext.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M ports/SkFontHost_FreeType.cpp View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10
reed1
I think this is correct, in that it should not affect clients that don't opt-in ...
10 years ago (2012-09-10 16:55:39 UTC) #1
tdanderson
On 2012/09/10 16:55:39, reed1 wrote: > I think this is correct, in that it should ...
10 years ago (2012-09-10 17:01:46 UTC) #2
reed1
(short-term) Good. Lets wrap this in a build-flag, as we've done for some Android changes ...
10 years ago (2012-09-10 17:50:11 UTC) #3
tdanderson
On 2012/09/10 17:50:11, reed1 wrote: > (short-term) Good. > > Lets wrap this in a ...
10 years ago (2012-09-11 18:29:10 UTC) #4
reed1
(assuming you added the build-flag in SkPaint.h as well) lgtm
10 years ago (2012-09-11 18:58:32 UTC) #5
tdanderson
On 2012/09/11 18:58:32, reed1 wrote: > (assuming you added the build-flag in SkPaint.h as well) ...
10 years ago (2012-09-11 19:00:20 UTC) #6
reed1
On 2012/09/11 19:00:20, tdanderson wrote: > On 2012/09/11 18:58:32, reed1 wrote: > > (assuming you ...
10 years ago (2012-09-11 19:04:32 UTC) #7
tdanderson
On 2012/09/11 19:04:32, reed1 wrote: > On 2012/09/11 19:00:20, tdanderson wrote: > > On 2012/09/11 ...
10 years ago (2012-09-11 20:27:03 UTC) #8
reed1
Ah! You need to construct the CL from a clean Skia checkout, not from the ...
10 years ago (2012-09-11 20:54:12 UTC) #9
tdanderson
10 years ago (2012-09-11 23:32:29 UTC) #10
On 2012/09/11 20:54:12, reed1 wrote:
> Ah!
> 
> You need to construct the CL from a clean Skia checkout, not from the
> partial, embedded checkout that chrome's DEPS file creates.
> 
> On Tue, Sep 11, 2012 at 4:27 PM,  <mailto:tdanderson@chromium.org> wrote:
> > On 2012/09/11 19:04:32, reed1 wrote:
> >>
> >> On 2012/09/11 19:00:20, tdanderson wrote:
> >> > On 2012/09/11 18:58:32, reed1 wrote:
> >> > > (assuming you added the build-flag in SkPaint.h as well)
> >> > > lgtm
> >> >
> >> > I did, and I just added you as reviewer for
> >> > https://codereview.appspot.com/6488085/ . Can these two CLs be
> >
> > landed at the
> >>
> >> > same time?
> >
> >
> >> Nope. Much better if you combine them into one CL. Just back up one
> >
> > directory
> >>
> >> before you run 'gcl change foo' and you should get all the changes at
> >
> > once.
> >
> > I don't think this will work for me since src/third_party/skia/src and
> > src/third_party/skia/include are two different repositories in my
> > current setup for some reason. Backing up to src/third_party/skia puts
> > me in the chromium repository. I'm trying to sort this out.
> >
> > https://codereview.appspot.com/6495089/

OK, everything is finally in one place now:
https://codereview.appspot.com/6506099/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b