Issue 6506099: Using the device scale factor for glyph positioning

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6506099: Using the device scale factor for glyph positioning

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by tdanderson

Modified:
11 years, 7 months ago

Reviewers:
reed1

CC:
rjkroege, behdad, bungeman of chrome, rbyers, wjmaclean

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Using the device scale factor for glyph positioning The master bug is http://code.google.com/p/chromium/issues/detail?id=138101 . The corresponding WebKit changes for this CL are here: https://bugs.webkit.org/show_bug.cgi?id=96137 BUG=

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -0 lines)			Patch
M	gyp/common_conditions.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	include/core/SkPaint.h	View	2 chunks	+17 lines, -0 lines	0 comments	Download
M	src/core/SkPaint.cpp	View	8 chunks	+33 lines, -0 lines	0 comments	Download
M	src/core/SkScalerContext.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/ports/SkFontHost_FreeType.cpp	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

tdanderson

Finally all of the changes are in one CL. reed@, please let me know if ...

11 years, 7 months ago (2012-09-11 23:38:04 UTC) #1

tdanderson

11 years, 7 months ago (2012-09-12 19:47:33 UTC) #3

On 2012/09/12 14:40:03, reed1 wrote:
> lgtm

wjmaclean@ committed this change for me, However there were two test failures:

../src/core/SkOrderedReadBuffer.cpp:199: failed assertion "index <
fFactoryCount" (full details
http://70.32.156.53:10115/builders/Skia_Linux_NoGPU/builds/515)

It seems this is related to my changes in SkPaint::flatten(),
SkPaint::unflatten(), and the value of |kPODPaintSize|.  Can someone who has
more familiarity with this area of the code offer any direction that will help
me to resolve these test failures?

Expand All Messages | Collapse All Messages