Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(594)

Issue 6506099: Using the device scale factor for glyph positioning

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by tdanderson
Modified:
9 years, 1 month ago
Reviewers:
reed1
CC:
rjkroege, behdad, bungeman of chrome, rbyers, wjmaclean
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Using the device scale factor for glyph positioning The master bug is http://code.google.com/p/chromium/issues/detail?id=138101 . The corresponding WebKit changes for this CL are here: https://bugs.webkit.org/show_bug.cgi?id=96137 BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -0 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkPaint.h View 2 chunks +17 lines, -0 lines 0 comments Download
M src/core/SkPaint.cpp View 8 chunks +33 lines, -0 lines 0 comments Download
M src/core/SkScalerContext.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3
tdanderson
Finally all of the changes are in one CL. reed@, please let me know if ...
9 years, 1 month ago (2012-09-11 23:38:04 UTC) #1
reed1
lgtm
9 years, 1 month ago (2012-09-12 14:40:03 UTC) #2
tdanderson
9 years, 1 month ago (2012-09-12 19:47:33 UTC) #3
On 2012/09/12 14:40:03, reed1 wrote:
> lgtm

wjmaclean@ committed this change for me, However there were two test failures:

../src/core/SkOrderedReadBuffer.cpp:199: failed assertion "index <
fFactoryCount" (full details
http://70.32.156.53:10115/builders/Skia_Linux_NoGPU/builds/515)

It seems this is related to my changes in SkPaint::flatten(),
SkPaint::unflatten(), and the value of |kPODPaintSize|.  Can someone who has
more familiarity with this area of the code offer any direction that will help
me to resolve these test failures?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b