Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(810)

Issue 6460087: code review 6460087: database/sql: check NumInput on Stmt.Exec

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 5 months ago by gwenn
Modified:
8 years ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

database/sql: check NumInput on Stmt.Exec Fixes issue 3678.

Patch Set 1 #

Patch Set 2 : diff -r f1bf0abeff93 https://code.google.com/p/go #

Patch Set 3 : diff -r 7677524b8a24 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r caf30a0fbd77 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -20 lines) Patch
M src/pkg/database/sql/sql.go View 1 2 3 3 chunks +6 lines, -20 lines 0 comments Download

Messages

Total messages: 5
gwenn
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
8 years, 3 months ago (2012-10-10 19:06:57 UTC) #1
bradfitz
Change commit description too. You can drop most the backstory. The bug and diff tell ...
8 years, 3 months ago (2012-10-10 22:23:02 UTC) #2
gwenn
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
8 years, 3 months ago (2012-10-11 19:38:06 UTC) #3
bradfitz
LGTM Sorry, this slips through the cracks.
8 years ago (2013-01-11 21:28:22 UTC) #4
bradfitz
8 years ago (2013-01-11 21:28:38 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=51bbb0535a60 ***

database/sql: check NumInput on Stmt.Exec

Fixes issue 3678.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/6460087

Committer: Brad Fitzpatrick <bradfitz@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b