Code review - Issue 6460087: code review 6460087: database/sql: check NumInput on Stmt.Exechttps://codereview.appspot.com/2013-01-11T21:28:38+00:00rietveld
Message from unknown
2012-08-14T17:16:54+00:00gwennurn:md5:145e02af48c9689e47c9f049e688922f
Message from unknown
2012-08-14T17:16:57+00:00gwennurn:md5:f0663dd504bd57e4eed0032576a76ff0
Message from unknown
2012-10-10T19:06:51+00:00gwennurn:md5:338712fcc1c53452409f0ccb183e793b
Message from gwenn.kahz@gmail.com
2012-10-10T19:06:57+00:00gwennurn:md5:ba5054c4b4afdb1a2b0f772b930ff399
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
I'd like you to review this change to
https://code.google.com/p/go
Message from bradfitz@golang.org
2012-10-10T22:23:02+00:00bradfitzurn:md5:4310ac7727e63f3da6736a9a3abd0eeb
Change commit description too. You can drop most the backstory. The bug and diff tell it.
database/sql: check NumInput on Stmt.Exec
Fixes issue 3678
https://codereview.appspot.com/6460087/diff/5001/src/pkg/database/sql/sql.go
File src/pkg/database/sql/sql.go (right):
https://codereview.appspot.com/6460087/diff/5001/src/pkg/database/sql/sql.go#newcode670
src/pkg/database/sql/sql.go:670: func checkInputAndExec(si driver.Stmt, args ...interface{}) (Result, error) {
bad name.
how about:
func resultFromStatement
Message from unknown
2012-10-11T19:38:03+00:00gwennurn:md5:ba81a21bc55455c3c7397407a8509562
Message from gwenn.kahz@gmail.com
2012-10-11T19:38:06+00:00gwennurn:md5:8bfbd86b72a7bf7a0ea7f55fb21a303b
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com),
Please take another look.
Message from bradfitz@golang.org
2013-01-11T21:28:22+00:00bradfitzurn:md5:871fbfc8067ed4c57ef964563c4b8107
LGTM
Sorry, this slips through the cracks.
Message from bradfitz@golang.org
2013-01-11T21:28:38+00:00bradfitzurn:md5:84d53a2da81779e1e86dc6f8c54a10e1
*** Submitted as https://code.google.com/p/go/source/detail?r=51bbb0535a60 ***
database/sql: check NumInput on Stmt.Exec
Fixes issue 3678.
R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/6460087
Committer: Brad Fitzpatrick <bradfitz@golang.org>