Issue 6307072: state: implement Machine.Units

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6307072: state: implement Machine.Units

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by rog

Modified:
11 years, 10 months ago

Reviewers:
mp+109572

Visibility:
Public.

Description

state: implement Machine.Units original merge proposal: https://codereview.appspot.com/6256070/ https://code.launchpad.net/~rogpeppe/juju-core/go-state-units-for-machine/+merge/109572 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: implement Machine.Units #

Total comments: 2

Patch Set 3 : state: implement Machine.Units #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -5 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/internal_test.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	state/machine.go	View	1 2	1 chunk	+20 lines, -0 lines	0 comments	Download
M	state/state_test.go	View		1 chunk	+64 lines, -0 lines	0 comments	Download
M	state/topology.go	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	state/unit.go	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	state/watcher.go	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/6307072/diff/2001/state/topology.go File state/topology.go (right): https://codereview.appspot.com/6307072/diff/2001/state/topology.go#newcode405 state/topology.go:405: func (t *topology) UnitsForMachine(machineKey string) []string { We're ...

11 years, 10 months ago (2012-06-12 13:38:20 UTC) #4

rog

11 years, 10 months ago (2012-06-12 13:47:03 UTC) #5

*** Submitted:

state: implement Machine.Units

original merge proposal:
https://codereview.appspot.com/6256070/

R=TheMue, fwereade, niemeyer
CC=
https://codereview.appspot.com/6307072

https://codereview.appspot.com/6307072/diff/2001/state/topology.go
File state/topology.go (right):

https://codereview.appspot.com/6307072/diff/2001/state/topology.go#newcode405
state/topology.go:405: func (t *topology) UnitsForMachine(machineKey string)
[]string {
On 2012/06/12 13:38:20, niemeyer wrote:
> We're missing a test for this. I guess we're alright, given that the Units
> implementation is pretty much exploring the functionality of this function
> exactly, with good testing.

that was my thought. this is an internal function after all.

Expand All Messages | Collapse All Messages