Issue 6256070: state: implement UnitsForMachine

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6256070: state: implement UnitsForMachine

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by rog

Modified:
11 years, 11 months ago

Reviewers:
mp+108020, niemeyer

Visibility:
Public.

Description

state: implement UnitsForMachine I'm not entirely sure where unitFromKey should live - better suggestions welcome. https://code.launchpad.net/~rogpeppe/juju/go-state-units-watcher/+merge/108020 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: implement UnitsForMachine #

Total comments: 2

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+122 lines, -2 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/state.go	View	1 chunk	+38 lines, -0 lines	2 comments	Download
M	state/state_test.go	View	1 chunk	+61 lines, -0 lines	0 comments	Download
M	state/topology.go	View	2 chunks	+21 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

Sorry, spoke too soon. LGTM with the following addressed: https://codereview.appspot.com/6256070/diff/2001/state/state.go File state/state.go (right): https://codereview.appspot.com/6256070/diff/2001/state/state.go#newcode254 state/state.go:254: ...

11 years, 11 months ago (2012-06-05 20:19:42 UTC) #3

niemeyer

11 years, 11 months ago (2012-06-06 20:19:14 UTC) #4

I'm confused. Your refactoring of units seems to bring AllUnits on Machine
already, in which case this branch is reimplementing a feature that is not
necessary.

Either way, I'm marking this branch as Rejected in Launchpad since we have to
move to juju-core. It may be reproposed there if it still makes sense after the
units change, for some reason.

Expand All Messages | Collapse All Messages