Issue 6256051: environs: add NewConfig

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6256051: environs: add NewConfig (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by dave

Modified:
11 years, 11 months ago

Reviewers:
mp+107358

Visibility:
Public.

Description

environs: add NewConfig NewConfig provides access to the EnvironConfig which is needed for https://codereview.appspot.com/6256050 "environs: add SetConfig" NewEnviron has been reimplmented on top of NewConfig. https://code.launchpad.net/~dave-cheney/juju/go-envrions-newconfig/+merge/107358 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: add NewConfig #

Patch Set 3 : environs: add NewConfig #

Total comments: 1

Patch Set 4 : environs: add NewConfig #

Patch Set 5 : environs: add NewConfig #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -5 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/open.go	View		2 chunks	+10 lines, -4 lines	0 comments	Download
M	environs/open_test.go	View	1 2 3	1 chunk	+25 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

dave_cheney.net

On 2012/05/25 11:01:02, dfc wrote: > Please take a look. This proposal continues on from ...

11 years, 11 months ago (2012-05-25 11:04:59 UTC) #3

niemeyer

LGTM https://codereview.appspot.com/6256051/diff/7/environs/open.go File environs/open.go (right): https://codereview.appspot.com/6256051/diff/7/environs/open.go#newcode26 environs/open.go:26: func NewConfig(attrs map[string]interface{}) (EnvironConfig, error) { I considered ...

11 years, 11 months ago (2012-05-25 20:35:11 UTC) #4

dave_cheney.net

11 years, 11 months ago (2012-05-26 01:58:59 UTC) #6

*** Submitted:

environs: add NewConfig

NewConfig provides access to the EnvironConfig which is needed for

https://codereview.appspot.com/6256050 "environs: add SetConfig"

NewEnviron has been reimplmented on top of NewConfig.

R=niemeyer
CC=
https://codereview.appspot.com/6256051

Expand All Messages | Collapse All Messages