Issue 6209092: environs: add NewConfig

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6209092: environs: add NewConfig (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 12 months ago by dave

Modified:
11 years, 12 months ago

Reviewers:
mp+106935, niemeyer

Visibility:
Public.

Description

environs: add NewConfig NewConfig provides access to the EnvironConfig which is needed for https://code.launchpad.net/~dave-cheney/juju/go-environs-setconfig/+merge/106930 NewEnviron has been reimplmented on top of NewConfig. https://code.launchpad.net/~dave-cheney/juju/go-environs-newconfig/+merge/106935 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: add NewConfig #

Patch Set 3 : environs: add NewConfig #

Patch Set 4 : environs: add NewConfig #

Patch Set 5 : environs: add NewConfig #

Created: 11 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -63 lines)			Patch
A	[revision details]	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/dummy/environs.go	View	1 2 3 4	8 chunks	+34 lines, -12 lines	0 comments	Download
M	environs/ec2/config_test.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	environs/ec2/ec2.go	View	1 2 3 4	13 chunks	+60 lines, -22 lines	0 comments	Download
M	environs/ec2/export_test.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	environs/ec2/state.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	environs/ec2/storage.go	View	1 2 3 4	5 chunks	+39 lines, -21 lines	0 comments	Download
M	environs/interface.go	View	1 2 3 4	1 chunk	+3 lines, -0 lines	0 comments	Download
M	environs/open.go	View		2 chunks	+10 lines, -4 lines	0 comments	Download
M	environs/open_test.go	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dave_cheney.net

On 2012/05/23 05:16:33, dfc wrote: > Please take a look. Please only review environs/open.go, for ...

11 years, 12 months ago (2012-05-23 05:19:55 UTC) #3

niemeyer

11 years, 12 months ago (2012-05-24 21:29:32 UTC) #5

Putting this back as WIP, as the diff continues to be dirty.

Expand All Messages | Collapse All Messages