Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(514)

Issue 6195098: Make \footnote work via \tweak (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by dak
Modified:
7 years, 8 months ago
Reviewers:
pkx166h, Graham Percival, carl.d.sorensen, Keith
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Make \footnote work via \tweak Allow Tweak_engraver to take a (grob.property) pair as tweak address Revert "Merge branch 'footnote' into HEAD" This reverts commit 2ec0cd55d55c49dee4e5604903dfab8ff4a089c4, reversing changes made to 0a0274a3bf5792dfb7ce3719f5dfaef36059affe. Those are the three commits currently making up this issue. The music function \footnote, in addition to the arguments it already takes, now takes an additional music argument, either a chord constituent, or a music event on its own, or a postevent (in which case, like \tweak, you should invoke \footnote with an explicit event character - in front of it). The footnote is visible on any Grob directly caused by the following event in the source code (the additional music argument), unless a grob-name is specified, in which case it will appear on any grob of that type _ultimately_ caused by the following event (a Flag is directly caused by a NoteHead grob, but ultimately by a NoteEvent). I had been considering placing the anchoring Music event as first argument of \footnote. However, that makes for totally awful nesting syntax in case you attach several footnotes to the same Music.

Patch Set 1 #

Patch Set 2 : Compatibility behavior by adding \default, cf footnote-break-visibility.ly #

Patch Set 3 : This is the version after running update-with-convert-ly.sh #

Patch Set 4 : Fix inline documentation of \footnote command #

Patch Set 5 : Manual changes to manual and regtests #

Total comments: 4

Patch Set 6 : Add footnote-music to grob-interface #

Patch Set 7 : Clear footnote-music property from grob after use #

Patch Set 8 : Garbage collection fixes #

Total comments: 10

Patch Set 9 : Rebase, include issue 2450 work #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+464 lines, -354 lines) Patch
M Documentation/de/notation/input.itely View 1 2 6 chunks +42 lines, -42 lines 0 comments Download
M Documentation/es/notation/input.itely View 1 2 6 chunks +42 lines, -42 lines 0 comments Download
M Documentation/fr/notation/input.itely View 1 2 6 chunks +42 lines, -42 lines 0 comments Download
M Documentation/ja/notation/input.itely View 1 2 6 chunks +42 lines, -42 lines 0 comments Download
M Documentation/notation/input.itely View 1 2 3 4 5 chunks +106 lines, -81 lines 4 comments Download
M input/regression/footnote.ly View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M input/regression/footnote-auto-numbering.ly View 1 2 3 4 2 chunks +4 lines, -5 lines 0 comments Download
M input/regression/footnote-auto-numbering-page-reset.ly View 1 2 3 4 2 chunks +4 lines, -5 lines 0 comments Download
M input/regression/footnote-auto-numbering-vertical-order.ly View 1 2 3 4 5 1 chunk +18 lines, -24 lines 0 comments Download
M input/regression/footnote-break-visibility.ly View 1 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/footnote-footer-padding.ly View 1 2 3 4 1 chunk +8 lines, -6 lines 0 comments Download
M input/regression/footnote-spanner.ly View 1 2 3 4 2 chunks +6 lines, -4 lines 0 comments Download
M input/regression/in-note.ly View 1 2 3 4 1 chunk +4 lines, -3 lines 0 comments Download
M lily/footnote-engraver.cc View 1 2 3 4 5 6 7 5 chunks +35 lines, -1 line 0 comments Download
M lily/grob.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M lily/parser.yy View 1 4 chunks +27 lines, -10 lines 0 comments Download
M lily/tweak-engraver.cc View 1 chunk +13 lines, -2 lines 0 comments Download
M ly/music-functions-init.ly View 1 2 3 4 5 6 7 8 2 chunks +58 lines, -29 lines 0 comments Download
M python/convertrules.py View 1 2 2 chunks +3 lines, -8 lines 0 comments Download
M scm/define-grob-properties.scm View 1 chunk +1 line, -0 lines 0 comments Download
M scm/define-music-types.scm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13
pkx166h
http://codereview.appspot.com/6195098/diff/4023/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6195098/diff/4023/Documentation/notation/input.itely#newcode1077 Documentation/notation/input.itely:1077: I'm not comfortable with tables/lists like this in the ...
7 years, 9 months ago (2012-05-17 17:53:17 UTC) #1
dak
http://codereview.appspot.com/6195098/diff/4023/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6195098/diff/4023/Documentation/notation/input.itely#newcode1077 Documentation/notation/input.itely:1077: On 2012/05/17 17:53:17, J_lowe wrote: > I'm not comfortable ...
7 years, 9 months ago (2012-05-17 18:20:33 UTC) #2
Carl
I think it's much clearer than it was, which is a definite improvement. I also ...
7 years, 9 months ago (2012-05-17 18:57:11 UTC) #3
dak
On 2012/05/17 18:57:11, Carl wrote: > I think it's much clearer than it was, which ...
7 years, 9 months ago (2012-05-17 19:28:49 UTC) #4
Carl
On 2012/05/17 19:28:49, dak wrote: > I think that I pretty much got the possibilities ...
7 years, 9 months ago (2012-05-17 21:36:53 UTC) #5
dak
On 2012/05/17 21:36:53, Carl wrote: > On 2012/05/17 19:28:49, dak wrote: > > > I ...
7 years, 9 months ago (2012-05-17 22:04:31 UTC) #6
Trevor Daniels
I've reviewed only the English input.itely file. This seems so much clearer now. I like ...
7 years, 9 months ago (2012-05-17 22:24:16 UTC) #7
pkx166h
Carl, Go for it. Just bear in mind that when someone like (Father Gilbert for ...
7 years, 9 months ago (2012-05-17 22:28:19 UTC) #8
dak
On 2012/05/17 22:28:19, J_lowe wrote: > Carl, > > Go for it. > > Just ...
7 years, 9 months ago (2012-05-17 23:08:15 UTC) #9
Graham Percival
There are a few questionable things in the docs, but I gather that the main ...
7 years, 9 months ago (2012-05-18 21:02:49 UTC) #10
dak
On 2012/05/18 21:02:49, Graham Percival wrote: > There are a few questionable things in the ...
7 years, 9 months ago (2012-05-18 22:09:19 UTC) #11
Carl
On 2012/05/18 22:09:19, dak wrote: > I would like to let Carl field this if ...
7 years, 9 months ago (2012-05-18 22:14:50 UTC) #12
Keith
7 years, 9 months ago (2012-05-21 06:19:01 UTC) #13
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b