code review 60100043: cmd/go, doc/go1.3.txt: misc/benchcmp has been replaced ...

cmd/go, doc/go1.3.txt: misc/benchcmp has been replaced by go tool benchcmp

Fixes issue 7016.

[josharian, 2014-02-04 18:47:11]

Sorry for the delay on this; I had family in town.

-josh

[josharian, 2014-02-04 18:47:32]

Hello r@golang.org (cc: adg@golang.org, bradfitz@golang.org, dave@cheney.net,
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[r, 2014-02-04 19:50:50]

LGTM

[r, 2014-02-04 19:52:35]

*** Submitted as https://code.google.com/p/go/source/detail?r=eeb3547ccd1b ***

cmd/go, doc/go1.3.txt: misc/benchcmp has been replaced by go tool benchcmp

Fixes issue 7016.

LGTM=r
R=r
CC=adg, bradfitz, dave, golang-codereviews
https://codereview.appspot.com/60100043

Committer: Rob Pike <r@golang.org>

[adg, 2014-02-25 21:49:47]

Why is this a "go tool" tool?

The other tools are invoked by the go tool (or were, in the case of godoc).

I don't see why this should be special cased. I don't want to add more special
cases.

[adg, 2014-02-25 21:51:12]

On 26 February 2014 08:49, <adg@golang.org> wrote:

> The other tools are invoked by the go tool (or were, in the case of
> godoc).
>

And by "the other tools" I mean vet, cover, and godoc.

[josharian, 2014-02-26 00:46:54]

> > The other tools are invoked by the go tool (or were, in the case of
> > godoc).
> >
> 
> And by "the other tools" I mean vet, cover, and godoc.

I'm not sure I follow; apologies.

This is invoked as `go tool benchmp`. Is your preference that folks wanting to
use it just do a regular `go get code.google.com/p/go.tools/cmd/benchcmp` and
run it as `$GOPATH/bin/benchcmp` instead of `go tool benchcmp`?

[adg, 2014-02-26 00:50:56]

Yes


On 26 February 2014 11:46, <josharian@gmail.com> wrote:

> > The other tools are invoked by the go tool (or were, in the case of
>> > godoc).
>> >
>>
>
>  And by "the other tools" I mean vet, cover, and godoc.
>>
>
> I'm not sure I follow; apologies.
>
> This is invoked as `go tool benchmp`. Is your preference that folks
> wanting to use it just do a regular `go get
>
code.google.com/p/go.tools/cmd/benchcmp`<http://code.google.com/p/go.tools/cmd/benchcmp>and
run it as
> `$GOPATH/bin/benchcmp` instead of `go tool benchcmp`?
>
> https://codereview.appspot.com/60100043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[adg, 2014-02-26 00:52:42]

To expand:

I know why vet and cover are special: the go tool uses them.
I know why godoc is special: we include it in binary releases (and it was
once invoked by the go tool).
What makes benchcmp more special than gotype, oracle, ssadump, goimports,
or even the trusty html2article?





On 26 February 2014 11:50, Andrew Gerrand <adg@golang.org> wrote:

> Yes
>
>
> On 26 February 2014 11:46, <josharian@gmail.com> wrote:
>
>> > The other tools are invoked by the go tool (or were, in the case of
>>> > godoc).
>>> >
>>>
>>
>>  And by "the other tools" I mean vet, cover, and godoc.
>>>
>>
>> I'm not sure I follow; apologies.
>>
>> This is invoked as `go tool benchmp`. Is your preference that folks
>> wanting to use it just do a regular `go get
>>
code.google.com/p/go.tools/cmd/benchcmp`<http://code.google.com/p/go.tools/cmd/benchcmp>and
run it as
>> `$GOPATH/bin/benchcmp` instead of `go tool benchcmp`?
>>
>> https://codereview.appspot.com/60100043/
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "golang-codereviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-codereviews+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>
>

[josharian, 2014-02-26 00:54:53]

> > This is invoked as `go tool benchmp`. Is your preference that folks
> > wanting to use it just do a regular `go get
> >
>
code.google.com/p/go.tools/cmd/benchcmp`<http://code.google.com/p/go.tools/cmd/benchcmp>and
> run it as
> > `$GOPATH/bin/benchcmp` instead of `go tool benchcmp`?

> Yes

Sounds fine to me, although it does make the initial "how to" instructions
(which I see Dave type out once a week) a tiny bit longer.

I'd like to hear from Rob, though, since `go tool benchcmp` was his suggestion
initially.

[r, 2014-02-26 01:47:57]

Andrew wins this one.

-rob

[adg, 2014-02-26 01:53:17]

Sent: https://codereview.appspot.com/68890043

[josharian, 2014-02-26 02:02:52]

On 2014/02/26 01:47:57, r wrote:
> Andrew wins this one.
> 
> -rob

Fine by me; thanks for weighing in. CL 68860044 is winging its way to you,
Andrew.

[rsc, 2014-03-31 15:44:25]

If you're going to do this at least update misc/benchcmp to tell people where it
went. I will send a CL.