Issue 68890043: code review 68890043: cmd/go: remove 'go tool benchcmp' and corresponding spe...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 68890043: code review 68890043: cmd/go: remove 'go tool benchcmp' and corresponding spe... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by adg

Modified:
11 years, 2 months ago

Reviewers:
gobot, josharian

CC:
r, josharian, golang-codereviews

Visibility:
Public.

Description

cmd/go: remove 'go tool benchcmp' and corresponding special case See the discussion on the original CL for context: https://codereview.appspot.com/60100043/

Patch Set 1 #

Patch Set 2 : diff -r 6de5a9a3f474 https://code.google.com/p/go #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -14 lines)			Patch
M	doc/go1.3.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/go/pkg.go	View	1 chunk	+11 lines, -12 lines	0 comments	Download
M	src/cmd/go/tool.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 2 months ago (2014-02-26 01:52:25 UTC) #1

josharian

On 2014/02/26 01:52:25, adg wrote: > Hello r (cc: mailto:golang-codereviews@googlegroups.com), > > I'd like you ...

11 years, 2 months ago (2014-02-26 02:04:09 UTC) #2

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=cb6df6612feb *** cmd/go: remove 'go tool benchcmp' and corresponding special case See ...

11 years, 2 months ago (2014-02-26 02:04:44 UTC) #3

Message was sent while issue was closed.

This CL appears to have broken the freebsd-amd64 builder.

Expand All Messages | Collapse All Messages